Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: return error to user if they provide a marker argument key that is not recognized #21

Open
lander2k2 opened this issue Jun 8, 2022 · 0 comments
Open

feat: return error to user if they provide a marker argument key that is not recognized #21

lander2k2 opened this issue Jun 8, 2022 · 0 comments
Assignees
@scottd018
Labels
good first issue Good for newcomers

Comments

@lander2k2
Copy link
Contributor

If you include a valid marker with an invalid argument key like this:

// +operator-builder:field:name=potato,tipe=string,default="apple"

In this case type is mispelled as tipe. Today the code generation continues. Will improve the UX to return an error to the user.
scottd018 pushed a commit that referenced this issue Jun 14, 2022
@AndriyKalashnykov @mrporcles
Add getting started guide (#21)
b484d74 
* Add getting started guide

* fixed spelling and formatting errors. expanded supported types

Signed-off-by: Paul Wiggett <[email protected]>

* general getting started guide updates

Signed-off-by: Paul Wiggett <[email protected]>

* fixed workload-collections link

Signed-off-by: Paul Wiggett <[email protected]>

Co-authored-by: Andriy Kalashnykov <[email protected]>
Co-authored-by: Paul Wiggett <[email protected]>
Signed-off-by: Jeff Davis <[email protected]>
@scottd018 scottd018 added the good first issue Good for newcomers label Jun 20, 2022
@scottd018 scottd018 self-assigned this Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottd018 scottd018

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lander2k2 @scottd018