Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to play section titles #1168

Closed
MithicSpirit opened this issue Jan 31, 2022 · 5 comments
Closed

Don't attempt to play section titles #1168

MithicSpirit opened this issue Jan 31, 2022 · 5 comments
Labels
bug This issue identifies a bug in Nuclear. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time.

Comments

@MithicSpirit
Copy link

Platform: Linux (Arch, using flatpak install)

Nuclear version: 0.6.16 (according to flatpak info org.js.nuclear.Nuclear)

Description of the issue:
Nuclear attempts to play section titles as if they were songs. For example:

  1. Set the metadata provider to Discogs
  2. Search for "Requiem", then find and click on this result
  3. Hit play, the "tracks" Requiem D-Moll KV 626, I. Introitus, II. Kyrie, etc. will be included in the queue

The issue with this is that these are not real tracks, but rather just section titles. In the Discogs page of this album they show up as bold with a darker background to show that. I have only tested this problem on with the Discogs provider, though it may also be present on others.

@MithicSpirit MithicSpirit added the bug This issue identifies a bug in Nuclear. label Jan 31, 2022
@haidang666 haidang666 added the good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. label Jan 31, 2022
@sewe2000
Copy link
Contributor

sewe2000 commented Jun 1, 2022

Could I work on this bug? Is there anyone working on it ?

@sewe2000
Copy link
Contributor

sewe2000 commented Jun 5, 2022

I can confirm the bug exists also in the AUR version.

@sewe2000
Copy link
Contributor

sewe2000 commented Jun 5, 2022

OK, I've fixed this bug in my nuclear version. Now I need to learn how to make a test for that. Here's a screenshot of search results which I've got:
image

As you can see, there's none of those headings appearing as tracks.

@mariadoggo
Copy link

Sorry, forgot to write that I would like to give this one a try!

@nukeop
Copy link
Owner

nukeop commented Aug 18, 2024

Going to be tracked in #1671 from now on

@nukeop nukeop closed this as completed Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue identifies a bug in Nuclear. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants