Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

[play] Kill old server after changing servers #10

Open
rgbkrk opened this issue Dec 26, 2017 · 4 comments
Open

[play] Kill old server after changing servers #10

rgbkrk opened this issue Dec 26, 2017 · 4 comments

Comments

@rgbkrk
Copy link
Member

rgbkrk commented Dec 26, 2017

ref: #2236

Maintainers: feel free to edit/update the description here.

/cc @mpacer @theengineear

@mpacer
Copy link
Member

mpacer commented Dec 28, 2017

It does seem like this feature already exists via

https://github.com/nteract/nteract/blob/82611f8e92949da8e145ecb38b19b6e828e13a1c/applications/play/components/Main.js#L54-L60

What needs to be made is the server killing feature, which currently has no epic (see the comments):

https://github.com/nteract/nteract/blob/82611f8e92949da8e145ecb38b19b6e828e13a1c/applications/play/redux/epics.js#L44-L48

So should we change this issue to be "kill oldServer after changing servers"?

Or is there a way in which this functionality is missing that I'm misunderstanding?

@rgbkrk
Copy link
Member Author

rgbkrk commented Dec 28, 2017

That sounds right. I just copied over the text that was in the top of the originating PR.

@rgbkrk rgbkrk changed the title [play] Ability to switch servers [play] Kill old server after changing servers Dec 28, 2017
@stale
Copy link

stale bot commented Apr 12, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Feb 7, 2019

This issue hasn't had any activity on it in the last 90 days. Unfortunately we don't get around to dealing with every issue that is opened. Instead of leaving issues open we're seeking to be transparent by closing issues that aren't being prioritized. If no other activity happens on this issue in one week, it will be closed.
It's more than likely that just by me posting about this, the maintainers will take a closer look at these long forgotten issues to help evaluate what to do next.
If you would like to see this issue get prioritized over others, there are multiple avenues 🗓:

  • Ask how you can help with this issue 👩🏿‍💻👨🏻‍💻
  • Help solve other issues the team is currently working on 👨🏾‍💻👩🏼‍💻
  • Donate to nteract so we can support developers to work on these features and bugs more regularly 💰🕐

Thank you!

@rgbkrk rgbkrk transferred this issue from nteract/nteract Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants