Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDENTIFY still uses short_id and long_id instead of client_id #141

Open
ashleywalsh opened this issue Jan 27, 2016 · 2 comments
Open

IDENTIFY still uses short_id and long_id instead of client_id #141

ashleywalsh opened this issue Jan 27, 2016 · 2 comments
Labels
feature

Comments

@ashleywalsh
Copy link

nsq.async.AsyncConn._on_connect() still sends short_id and long_id fields.
@mreiferson
Copy link
Member

Ahh, good catch, thanks!

Need to circle back around to deprecating all of the old functionality across nsqd and official client libs.

@mreiferson mreiferson changed the title IDENTITY still uses short_id and long_id instead of client_id IDENTIFY still uses short_id and long_id instead of client_id Jan 28, 2016
@ploxiln
Copy link
Member

ploxiln commented Dec 11, 2017

short_id and long_id are still included for backwards compatibility, but the new fields were added in #169 (just leaving a note for future reference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mreiferson @ashleywalsh @ploxiln