Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting unnecessary maps in the config #2993

Open
End-rey opened this issue Oct 31, 2024 · 0 comments
Open

Deleting unnecessary maps in the config #2993

End-rey opened this issue Oct 31, 2024 · 0 comments
Labels
config Configuration format update or breaking change enhancement Improving existing functionality I2 Regular impact neofs-storage Storage node application issues S3 Minimally significant U3 Regular
Milestone

Comments

@End-rey
Copy link
Contributor

End-rey commented Oct 31, 2024

Is your feature request related to a problem? Please describe.

I'm always frustrated when there are fields in the config that are difficult to validate, particularly in the form of a map.
In the node config, there are fields:

  • node.attribute_*
  • storage.shard.*

Describe the solution you'd like

Make these fields lists.

Describe alternatives you've considered

Leave everything as it is, but then complex validation will remain and it will not be easy to reuse the config.

Additional context

Refs #2981 (comment).
After this, we can use viper.UnmarshalExact for validation and reuse the config in the code.

@End-rey End-rey added enhancement Improving existing functionality neofs-storage Storage node application issues U3 Regular config Configuration format update or breaking change S3 Minimally significant I2 Regular impact labels Oct 31, 2024
@roman-khimov roman-khimov added this to the v0.45.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Configuration format update or breaking change enhancement Improving existing functionality I2 Regular impact neofs-storage Storage node application issues S3 Minimally significant U3 Regular
Projects
None yet
Development

No branches or pull requests

2 participants