-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor upload-bin
handler to reuse more of SDK built-in functionality
#3714
Labels
Milestone
Comments
AnnaShaleva
added
feature
Completely new functionality
U3
Regular
cli
Command line interface
S4
Routine
I4
No visible changes
labels
Dec 2, 2024
Only after nspcc-dev/neofs-node#2721 (comment) and resolved nspcc-dev/neofs-node#2990, because such "improper" usage of NeoFS is intended to prevent duplicates. Currently, we can only have duplicates because of partially completed search results. Such object creation reduces the likelihood of duplicates with the current search version. |
AliceInHunterland
added a commit
that referenced
this issue
Dec 12, 2024
Close #3714 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
added a commit
that referenced
this issue
Dec 13, 2024
Close #3714 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
added a commit
that referenced
this issue
Dec 13, 2024
Close #3714 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
added a commit
that referenced
this issue
Dec 13, 2024
Close #3714 Signed-off-by: Ekaterina Pavlova <[email protected]>
Ref. #3654 (comment). |
AliceInHunterland
added a commit
that referenced
this issue
Dec 13, 2024
Close #3714 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
added a commit
that referenced
this issue
Dec 13, 2024
Close #3714 Signed-off-by: Ekaterina Pavlova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
upload-bin
has code that manually constructs object before uploading it to NeoFS:neo-go/cli/util/upload_bin.go
Lines 593 to 616 in 6a7d2bc
Describe the solution you'd like
NeoFS SDK already has a proper object construction code, we need to reuse it.
Describe alternatives you've considered
Keep it as is, depends on the result of #3652.
The text was updated successfully, but these errors were encountered: