Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NeoFS BlockFetcher/BlockUploader object attributes #3631

Closed
AnnaShaleva opened this issue Oct 21, 2024 · 1 comment · Fixed by #3637
Closed

Improve NeoFS BlockFetcher/BlockUploader object attributes #3631

AnnaShaleva opened this issue Oct 21, 2024 · 1 comment · Fixed by #3637
Labels
feature Completely new functionality I3 Minimal impact S4 Routine U4 Nothing urgent
Milestone

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

Existing NeoFS containers that store Neo chains have two problems:

  1. Object attributes start from lowercase letters: block:0, index:0.
  2. Both block and index file objects don't have network magic included into attributes, and hence it's impossible to learn the network of the block or index file without additional external knowledge like this:
neo-testnet container: HmP48JvCcmiEbJemG7jFNEg2qkdCTx4thD3EwWUi288Q
neo-mainnet container: 2W2c7qHqicZJJdRG134k7eusZqidkk3KBDNgeLL45nn2
fschain testnet 4SJK36y4JGZJ5rjXsGWsJ3yiWrcvEANXBBHThQ6eErsq
fschain mainnet 5oAvDsnVcpGEf8KM4nxNB52wqZASjbr4CSszbW9iseCk

Describe the solution you'd like

Reuploading currently used containers doesn't make sense, but for neo-project/neo#3463 it should be done:

  1. Capitalize block objects and index file objects attributes.
  2. Add network magic attribute to both block and index file objects.

Describe alternatives you've considered

Leave it as is, it also works.

@AnnaShaleva AnnaShaleva added feature Completely new functionality I3 Minimal impact U4 Nothing urgent S4 Routine labels Oct 21, 2024
AliceInHunterland added a commit that referenced this issue Oct 21, 2024
Capitalize block objects and index file objects attributes.
Add network magic attribute to both block and index file objects.

Close #3631

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Oct 21, 2024
Capitalize block objects and index file objects attributes.
Add network magic attribute to both block and index file objects.

Close #3631

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AnnaShaleva
Copy link
Member Author

We have to reupload existing chains anyway since there are a lot of corrupted blocks/index files due to script bugs, hence we may improve format right now.

@AnnaShaleva AnnaShaleva added this to the v0.106.4 milestone Oct 22, 2024
AliceInHunterland added a commit that referenced this issue Oct 22, 2024
Capitalize block objects and index file objects attributes.
Add network magic attribute to both block and index file objects.

Close #3631

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Oct 22, 2024
Capitalize block objects and index file objects attributes.
Add network magic attribute to both block and index file objects.

Close #3631

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Oct 23, 2024
Capitalize block objects and index file objects attributes.
Add network magic attribute to container.

Close #3631

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Oct 23, 2024
Capitalize block objects and index file objects attributes.
Add network magic attribute to container.

Close #3631

Signed-off-by: Ekaterina Pavlova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Completely new functionality I3 Minimal impact S4 Routine U4 Nothing urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant