Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notary service doesn't start its work with GenesisRoles set #3228

Closed
AnnaShaleva opened this issue Nov 24, 2023 · 0 comments · Fixed by #3229
Closed

Notary service doesn't start its work with GenesisRoles set #3228

AnnaShaleva opened this issue Nov 24, 2023 · 0 comments · Fixed by #3229
Assignees
Labels
bug Something isn't working
Milestone

Comments

@AnnaShaleva
Copy link
Member

Ref. nspcc-dev/neofs-node#2652 (comment).

With P2PNotary node role designated via node configuration (ref. #3168) happens the following situation on node start. According to the node log, Notary service is up and running, but it doesn't actually starts signature collection. P2PNotaryRequests can be added to the pool and after VUB time comes, they are removed from the Notary pool without any side-effects.

@AnnaShaleva AnnaShaleva added the bug Something isn't working label Nov 24, 2023
@AnnaShaleva AnnaShaleva added this to the v0.104.0 milestone Nov 24, 2023
@AnnaShaleva AnnaShaleva self-assigned this Nov 24, 2023
AnnaShaleva added a commit that referenced this issue Nov 24, 2023
1. Initialise services dependant on roles designation based on N+1
   block so that Genesis roles extension work properly. There's not
   much sence to fetch node roles information for the latest persisted
   block because Designation contract itself makes designated nodes
   responsible since the next subsequent block.
2. Perform initialisation of StateRoot service with designated
   StateValidator's node list in the service constructor. There's no need
   to wait until the next role update event, and it may lead to inaccuraces
   in service work on SIGHUP/server restart.

Close #3228.

Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva added a commit that referenced this issue Nov 24, 2023
Initialise services dependant on roles designation based on N+1
block so that Genesis roles extension work properly. There's not
much sence to fetch node roles information for the latest persisted
block because Designation contract itself makes designated nodes
responsible since the next subsequent block.

A part of #3228.

Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva added a commit that referenced this issue Nov 24, 2023
Perform initialisation of StateRoot service with designated
StateValidator's node list in the service constructor. There's no need
to wait until the next role update event, and it may lead to inaccuraces
in service work on SIGHUP/server restart.

A part of #3228.

Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva added a commit that referenced this issue Nov 24, 2023
Initialise services dependant on roles designation based on N+1
block so that Genesis roles extension work properly. There's not
much sence to fetch node roles information for the latest persisted
block because Designation contract itself makes designated nodes
responsible since the next subsequent block.

A part of #3228.

Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva added a commit that referenced this issue Nov 24, 2023
Perform initialisation of StateRoot service with designated
StateValidator's node list in the service constructor. There's no need
to wait until the next role update event, and it may lead to inaccuraces
in service work on SIGHUP/server restart.

A part of #3228.

Signed-off-by: Anna Shaleva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant