Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binder PR comments #400

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

jrbourbeau
Copy link
Collaborator

xref #399

cc @MattF-NSIDC

Copy link

github-actions bot commented Dec 5, 2023

Binder 👈 Launch a binder notebook on this branch for commit 349900d

I will automatically update this comment whenever this PR is modified

@jrbourbeau
Copy link
Collaborator Author

So the binder comment still happened here. My guess is it may require the changes here to be on main. Happy to push up an empty PR to test after this PR has been merged

@MattF-NSIDC
Copy link

MattF-NSIDC commented Dec 5, 2023

So the binder comment still happened here. My guess is it may require the changes here to be on main.

I think RTD behaves the same way.

@betolink do you think we should try to fix Binder before AGU for any reason?

Copy link

@MattF-NSIDC MattF-NSIDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrbourbeau jrbourbeau merged commit f2b8e78 into nsidc:main Dec 5, 2023
7 checks passed
@jrbourbeau jrbourbeau deleted the remove-binder-comment branch December 5, 2023 17:32
@jrbourbeau jrbourbeau mentioned this pull request Dec 5, 2023
jhkennedy added a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants