Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll up dependabot GHA updates into one PR #380

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

MattF-NSIDC
Copy link

@MattF-NSIDC MattF-NSIDC commented Nov 30, 2023

If anyone approves, please also merge :)

Copy link

Binder 👈 Launch a binder notebook on this branch for commit b8852eb

I will automatically update this comment whenever this PR is modified

@MattF-NSIDC MattF-NSIDC changed the title Rollup dependabot GHA updates into one PR Roll up dependabot GHA updates into one PR Nov 30, 2023
Copy link
Collaborator

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do this because I find dependency issues much easier to catch and work through in isolated PRs. With a monthly cadence and the lower number of actions compared to pip dependencies, I didn't think this would be a significant burden outside of when we first turn it on.

That said, I'm probably going to be the least-frequent dependabot reviewer/merger^ so I'm going to approve and leave it up to you.


^My team likes daily cadence and individual PRs and that's entirely too much so I've effectively been trained now to ignore dependabot PRs and let them handle it.

@MattF-NSIDC
Copy link
Author

Found the prior PR on the subject, but unfortunately, it doesn't include discussion: #340

I searched on Slack for our discussion on this subject and turned up nothing. Possibly lost in the 90-day void. 😭

I've effectively been trained now to ignore dependabot PRs

That's the concern that came up in our prior discussions. We (@betolink , @jrbourbeau, I think ?) acknowledged we have well over 100 closed dependabot PRs and were training ourselves to ignore them (https://github.com/nsidc/earthaccess/pulls?q=is%3Apr+is%3Aclosed+author%3Aapp%2Fdependabot+).

I find dependency issues much easier to catch and work through in isolated PRs.

I see the value there! With GitHub Actions, the number of dependencies is much smaller, so maybe handling them individually would be easy. Honestly, I don't feel strongly and am OK with closing this PR if someone else feels strongly. I'd like it if that person who feels strongly (if there is one) helps us get through the initial flood of PRs :)

@jhkennedy jhkennedy merged commit 5e6b859 into main Nov 30, 2023
11 checks passed
@MattF-NSIDC MattF-NSIDC deleted the reduce-dependabot-gha-spam branch November 30, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants