Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add comment to PR that requires maintainer to review and rerun integration tests #824

Closed
chuckwondo opened this issue Sep 26, 2024 · 2 comments · Fixed by #842

Comments

@chuckwondo
Copy link
Collaborator

As a follow-on to Allow maintainers to run integration tests on PR from a fork, it would be very convenient to enhance the GitHub integration-tests workflow to post a comment to the PR when it requires a maintainer to perform a security review and re-run the tests, and the comment should include a link to the GitHub page for the failed integration tests build, where the maintainer can then click the "Rerun" button.

While a maintainer can currently see failed builds and navigate to them to hit the Rerun button, adding a comment to the PR would make the needed action visible in the PR itself.

@itcarroll
Copy link
Collaborator

Is this fixed? If I understand correctly, the fix ought to have resulted in a bot comment on #909, right?

@mfisher87
Copy link
Collaborator

This isn't working as expected. The bot comments are going in the wrong PR! #922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants