Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label suggestions #760

Closed
mfisher87 opened this issue Jul 11, 2024 · 6 comments
Closed

Label suggestions #760

mfisher87 opened this issue Jul 11, 2024 · 6 comments
Assignees
Labels
impact: documentation Improvements or additions to documentation

Comments

@mfisher87
Copy link
Collaborator

mfisher87 commented Jul 11, 2024

I think we can make our labels a bit more clear by making them multi-part with a delimiter (: or /). Many other projects do this, e.g. matplotlib. I don't have other great examples off the top of my head. What other projects are absolutely rocking the labels?

To start with, I propose:

#281 offers us a mechanism to automatically apply these labels as issues are created. It also offers a mechanism to remove or avoid some labels by directing users away from Issues and towards a more appropriate place, e.g. type/feature-request need not exist as a "request" should (IMO :) ) start in Discussions and only become an issue once we agree it is a feature we will implement. Same for type/question.

I also propose colorizing the items based on the group they're in!

@asteiker
Copy link
Member

asteiker commented Dec 7, 2024

@mfisher87 I took an initial stab at this:

  • After looking at the matlab example I was actually keen to use a : instead of / as the delimiter, as a slash could imply either/or. This seemed more intuitive to me.
  • I updated colors to be mostly consistent per grouping, but I'm not set anything if we want to change the color schemes. I did keep type: bug as red to highlight bugs specifically but I can change this if it's confusing.
  • For all labels you suggested to remove I made sure to check on existing issues. For the github_actions label in particular, I went ahead and deleted, but I wasn't sure if dependabot was adding this automatically or not (see Bump the gha-dependencies group with 2 updates #885 as an example).
  • I deleted hackathon and added needs: help if it didn't already exist. It feels like we can use needs: help to identify issues that are good candidates to work at a hackday.

I still need to go through type: question. We have 8 open issues so I wanted to dig into those more before simply converting those to discussions or doing anything else with that one.

@mfisher87
Copy link
Collaborator Author

Amazing work! I love how organized the labels page feels now 🤩

After looking at the matlab example I was actually keen to use a : instead of / as the delimiter, as a slash could imply either/or. This seemed more intuitive to me.

Makes sense to me too!

  • I updated colors to be mostly consistent per grouping, but I'm not set anything if we want to change the color schemes.

Not sure I understand the bold part. My main thought on the colors is that the "impact" category color is too close to the "good first issue" color, which I think should keep its default color for recognizability.

I deleted hackathon and added needs: help if it didn't already exist. It feels like we can use needs: help to identify issues that are good candidates to work at a hackday.

Reasonable! We hadn't developed a pattern of using that label in the actual hackathons so it wasn't really serving its purpose.

@asteiker
Copy link
Member

I missed a word above, no wonder that didn't make sense!

I'm not set on anything if we want to change the color schemes.

I thought the same thing on the colors being too close together on those categories - I'll update now.

@mfisher87
Copy link
Collaborator Author

Oh, of course! How did I miss that 😆 Thanks, Amy!

@asteiker
Copy link
Member

I reviewed all issues with the question label and either converted to discussion or updated the label to needs: feedback depending on the context. I think this is good to close out unless you see anything else we're missing here @mfisher87 !

@mfisher87
Copy link
Collaborator Author

Awesome work! I think we're good to call this "complete" as well. 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: documentation Improvements or additions to documentation
Projects
Status: Done
Development

No branches or pull requests

2 participants