Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleshed out contributing docs to include pre-commit,style,build info #744

Merged
merged 9 commits into from
Jul 9, 2024

Conversation

Sherwin-14
Copy link
Contributor

@Sherwin-14 Sherwin-14 commented Jul 3, 2024

I did the changes as discussed. Please have a look at it :)


📚 Documentation preview 📚: https://earthaccess--744.org.readthedocs.build/en/744/

Copy link
Collaborator

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I just have some nit-picky grammar/style comments.

docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
@mfisher87
Copy link
Collaborator

Hey @Sherwin-14, are you ready for another review? If so, can you please mark all the completed comments as "resolved" and then click the "Re-request review" button?

image

@Sherwin-14 Sherwin-14 requested a review from chuckwondo July 8, 2024 17:16
docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
@mfisher87
Copy link
Collaborator

pre-commit.ci autofix

@mfisher87
Copy link
Collaborator

pre-commit.ci autofix

@itcarroll itcarroll self-requested a review July 9, 2024 17:59
@mfisher87 mfisher87 dismissed chuckwondo’s stale review July 9, 2024 18:00

Requested changes applied

@mfisher87 mfisher87 merged commit f4caacb into nsidc:main Jul 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants