Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate dependency lists in conda environment YAML files #618

Closed
Tracked by #614
mfisher87 opened this issue Jun 26, 2024 · 2 comments
Closed
Tracked by #614

Remove duplicate dependency lists in conda environment YAML files #618

mfisher87 opened this issue Jun 26, 2024 · 2 comments
Labels
needs: help Extra attention is needed type: enhancement New feature or request

Comments

@mfisher87
Copy link
Collaborator

mfisher87 commented Jun 26, 2024

We could:

  • Remove them. Personally, I don't think this pure python project has a reason to include them. We can advise conda users to use conda to create the environment, but use pip to install into it.
  • Replace them with environment specification files that don't duplicate the dependency lists:
    name: earthaccess
    channels:
      - conda-forge
      - nodefaults
    dependencies:
      - python>=3.9
      - pip
      - pip:
          - --editable .[dev]
@mfisher87 mfisher87 changed the title Remove conda dependency files. I don't think this pure python project has a reason to include them. We can advise conda users to use conda to create the environment, but use pip to install into it. It's a hassle to manage duplicated dependency lists. I believe someone mentioned that the mindeps environment can be dynamically calculated as well. Remove duplicate dependency lists in conda environment YAML files Jun 26, 2024
@mfisher87 mfisher87 added type: enhancement New feature or request needs: help Extra attention is needed labels Jun 26, 2024
@itcarroll
Copy link
Collaborator

I knew I could find another one fixed by #733. @mfisher87 was on a tear!

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in earthaccess project Sep 18, 2024
@mfisher87
Copy link
Collaborator Author

Love it! Thanks for digging for these Ian!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: help Extra attention is needed type: enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants