Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial PR template #613

Merged
merged 10 commits into from
Jul 9, 2024
Merged

Initial PR template #613

merged 10 commits into from
Jul 9, 2024

Conversation

mfisher87
Copy link
Collaborator

@mfisher87 mfisher87 commented Jun 25, 2024

Addresses #281 but doesn't resolve it. We still need issue templates. We should break that ticket in to pieces.

cc @Sherwin-14


📚 Documentation preview 📚: https://earthaccess--613.org.readthedocs.build/en/613/

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
Copy link
Collaborator

@itcarroll itcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether it should be in the template or contributing, but can we say what to expext in terms of maintainer review? A contributor should not expect any comments or action until either help is requested or the PR is marked as ready for review.

.github/pull_request_template.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
@Sherwin-14
Copy link
Contributor

Sherwin-14 commented Jul 1, 2024

Hey all, I found these resources let me know if all this is relevant

Pull request template - https://github.com/forem/forem/blob/main/.github/PULL_REQUEST_TEMPLATE.md

Repo for Issue and PR templates - https://github.com/devspace/awesome-github-templates?tab=readme-ov-file.

The Repo does have some missing issue templates but I guess it shouldn't be an issue because there are a lot of them.

@mfisher87
Copy link
Collaborator Author

pre-commit.ci autofix

@mfisher87 mfisher87 dismissed danielfromearth’s stale review July 9, 2024 17:14

Changes addressed

@mfisher87 mfisher87 merged commit 7872750 into main Jul 9, 2024
12 of 16 checks passed
@mfisher87 mfisher87 deleted the pr-template branch July 9, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants