Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In development doc, a parenthetical about version matching is confusing #543

Open
andypbarrett opened this issue Apr 26, 2024 · 0 comments

Comments

@andypbarrett
Copy link
Collaborator

andypbarrett commented Apr 26, 2024

In addition, you must also add a corresponding entry to
`ci/environment-mindeps.yaml`.  You'll notice in this file that required
dependencies should be pinned exactly to the versions specified in
`pyproject.toml` (after changing `^` to `>=` there), and that development
dependencies should be left unpinned.

The sentence in parenthesis creates confusion. My reading is that in pyproject.toml dependencies should not be pinned but in environment-mindeps.yaml they should be pinned.

I wonder if adding an example of how entries should look like in each file would help.

Originally posted by @andypbarrett in #533 (comment)

@mfisher87 mfisher87 changed the title The sentence in parenthesis creates confusion. My reading is that in pyproject.toml dependencies should not be pinned but in environment-mindeps.yaml they should be pinned. In development doc, a parenthetical about version matching is confusing Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant