Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Ruff rules #381

Closed
MattF-NSIDC opened this issue Nov 30, 2023 · 2 comments
Closed

More Ruff rules #381

MattF-NSIDC opened this issue Nov 30, 2023 · 2 comments
Labels
impact: automation CI, CD, or other automation

Comments

@MattF-NSIDC
Copy link

MattF-NSIDC commented Nov 30, 2023 •
edited
Loading

Continuing discussion from here: #372 (comment)

PyUpgrade is one of my favorite rulesets, but we'll need to set it up with target-version of 3.8 to avoid upgrading our code out of compatibility with our target Pythons :)
@MattF-NSIDC MattF-NSIDC added the impact: automation CI, CD, or other automation label Nov 30, 2023
@MattF-NSIDC MattF-NSIDC mentioned this issue Nov 30, 2023
Merged
@jhkennedy
Copy link
Collaborator

@MattF-NSIDC woops, we opened the same issue 🤣 . I added a list of potential rule in #383 . We could make this one specifically related to pyupgrade or close 383/this.

@MattF-NSIDC
Copy link
Author

Let's close this one, yours has more detail :)

@MattF-NSIDC MattF-NSIDC closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in earthaccess project Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact: automation CI, CD, or other automation
Projects
earthaccess project
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhkennedy @MattF-NSIDC