Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to configure the colours used by nx run-many (to avoid red) #19901

Open
1 task
hisuwh opened this issue Oct 27, 2023 · 5 comments · May be fixed by #29026
Open
1 task

Ability to configure the colours used by nx run-many (to avoid red) #19901

hisuwh opened this issue Oct 27, 2023 · 5 comments · May be fixed by #29026
Assignees
@AgentEnder
Labels
community This is a good first issue for contributing scope: core core nx functionality type: feature

Comments

@hisuwh
Copy link

hisuwh commented Oct 27, 2023 •
edited
Loading

Description

When calling nx run-many it helpfully shows each project script in a different colour. It would be good if we could configure the colours this uses - or at the very least disable red from being used.

Motivation

Red is the colour associated with errors - whenever I see this in my console I immediately think there is a problem. This unnecessarily grabs my attention when nx has chosen to use red to colour-code one of my projects:

image

Suggested Implementation

Give the option to define a list of colours, or even colours for each specific project so it's consistent on different machines.

Alternate Implementations

Option to disable red colours from being used.
@AgentEnder AgentEnder added the scope: core core nx functionality label Oct 31, 2023
@mmellado
Copy link

In addition to this, more often than not I see nx run-many using the same color for multiple processes, red being most often the one picked. Probably a coincidence, but I completely agree that red should probably be avoided for nx run-many

@FrozenPandaz FrozenPandaz added the community This is a good first issue for contributing label May 15, 2024
@FrozenPandaz
Copy link
Collaborator

Sure, would someone like to contribute a PR?

The colors are listed here: https://github.com/nrwl/nx/blob/master/packages/nx/src/tasks-runner/forked-process-task-runner.ts#L516~

Could you change the red colors to something more Red-Orange?

@hisuwh
Copy link
Author

hisuwh commented May 24, 2024

There's no blues in that list? Just replace the reds with blues?

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it hasn't had any activity for 6 months.
Many things may have changed within this time. The issue may have already been fixed or it may not be relevant anymore.
If at this point, this is still an issue, please respond with updated information.
It will be closed in 21 days if no further activity occurs.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Nov 21, 2024
@hisuwh hisuwh linked a pull request Nov 21, 2024 that will close this issue
Open
@hisuwh
Copy link
Author

hisuwh commented Nov 21, 2024

I've submitted a PR for this issue

@github-actions github-actions bot removed the stale label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgentEnder AgentEnder

Labels
community This is a good first issue for contributing scope: core core nx functionality type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(nx): replace red in console with blue hisuwh/nx
4 participants
@mmellado @hisuwh @AgentEnder @FrozenPandaz