Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrf fromlist] tests: arch: arm: arm_irq_vector_table: Fix for nRF54H20 #2311

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[nrf fromlist] tests: arch: arm: arm_irq_vector_table: Fix for nRF54H20 #2311

wants to merge 1 commit into from
+6 −0

Conversation

adamkondraciuk
Copy link
Contributor

Fix failing tests for nRF54H20 targets.

@NordicBuilder NordicBuilder mentioned this pull request Nov 28, 2024
Open
nordic-piks
nordic-piks approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@nordic-piks nordic-piks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this fix test tests/arch/arm/arm_irq_vector_table works.

@nordic-piks
Copy link
Contributor

What about those tests:
- arch.arm.interrupt.no_optimizations
- arch.arm.swap.common.no_optimizations
- arch.arm.swap.common.fpu_sharing.no_optimizations

ie the failure was similar, do they need similar fix?

@adamkondraciuk adamkondraciuk force-pushed the NRFX-6718-fix-failin-irq-vector-table-test branch from 5d6be01 to f8370da Compare December 11, 2024 13:14
@adamkondraciuk adamkondraciuk changed the title [nrf noup] tests: arch: arm: arm_irq_vector_table: Fix for nRF54H20 [nrf fromlist] tests: arch: arm: arm_irq_vector_table: Fix for nRF54H20 Dec 11, 2024
@adamkondraciuk adamkondraciuk marked this pull request as ready for review December 11, 2024 13:15
@adamkondraciuk adamkondraciuk force-pushed the NRFX-6718-fix-failin-irq-vector-table-test branch from f8370da to 2dd5918 Compare December 11, 2024 13:19
@adamkondraciuk
Copy link
Contributor Author

What about those tests: - arch.arm.interrupt.no_optimizations - arch.arm.swap.common.no_optimizations - arch.arm.swap.common.fpu_sharing.no_optimizations

ie the failure was similar, do they need similar fix?
Probably this is

What about those tests: - arch.arm.interrupt.no_optimizations - arch.arm.swap.common.no_optimizations - arch.arm.swap.common.fpu_sharing.no_optimizations

ie the failure was similar, do they need similar fix?

I tried it: At least for the first one it helps, but I'm not sure whether the reason is the same.

@adamkondraciuk adamkondraciuk added this to the ncs-2.9.0-nRF54H20 milestone Dec 13, 2024
@adamkondraciuk
[nrf fromlist] tests: arch: arm: arm_irq_vector_table: Fix for nRF54H20
55d89a6 
Fix failing tests for nRF54H20 targets.

Upstream PR #: 82252

Signed-off-by: Adam Kondraciuk <[email protected]>
@adamkondraciuk adamkondraciuk force-pushed the NRFX-6718-fix-failin-irq-vector-table-test branch from 2dd5918 to 55d89a6 Compare December 13, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstasiaknordic mstasiaknordic mstasiaknordic approved these changes

@nordic-piks nordic-piks nordic-piks approved these changes

@nordic-segl nordic-segl nordic-segl approved these changes

@nika-nordic nika-nordic nika-nordic approved these changes

@kl-cruz kl-cruz kl-cruz approved these changes

@katgiadla katgiadla Awaiting requested review from katgiadla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ncs-2.9.0-nRF54H20
Development

Successfully merging this pull request may close these issues.
6 participants
@adamkondraciuk @nordic-piks @kl-cruz @nika-nordic @nordic-segl @mstasiaknordic