-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport v3.7.99-ncs1-branch] wifi: Fixes from RC1 testing #2225
Merged
rlubos
merged 6 commits into
v3.7.99-ncs1-branch
from
backport-2221-to-v3.7.99-ncs1-branch
Nov 5, 2024
Merged
[Backport v3.7.99-ncs1-branch] wifi: Fixes from RC1 testing #2225
rlubos
merged 6 commits into
v3.7.99-ncs1-branch
from
backport-2221-to-v3.7.99-ncs1-branch
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a3a28db. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit a7efd34)
Fix the noise during boot. Upstream PR #: 80858 Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 0d1bb86)
In case the driver UP fails, the FMAC context will be NULL, so, add a NULL check in the DOWN. Fixes a crash seen when working with unprogrammed OTP (no MAC) that fails the interface UP. Upstream PR #: 80858 Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 0debaa0)
This is needed to ensure Wi-Fi can always be used. Upstream PR #: 80822 Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit f2efee5)
Some spi drivers do not allow the send buffer and receive buffer to be empty at the same time, if this happens it will cause the spi to be unable to communicate with the nrf7002, so add the receive buffer for the discard byte in the spim_xfer_rx. Fix #80686 Upstream PR #: 80787 Signed-off-by: Hongquan Li <[email protected]> (cherry picked from commit e26e2a2)
With introduction of Raw modes, nRF70 driver now advertises get_c onfig OP, but doesn't implement all types. This causes problems two-fold with checksum calculations: 1. The "config" isn't uninitialized, so, every call returns differnet values. So, for UDP header checksum would be done and pkt->chksumdone would be set. But for IPv4 header checksum might be skipped. 2. Even if we initialize to zero, then network stack gets all zeros and calculates checksum by itself rendering offload moot. There is another problem in #1, as there is only single flag for pkt for all checksum, nRF70 driver sees this and tells UMAC to skip checksum for the entire packet. The design isn't coherent, and should be converted to communicate per-type checksum status (some are filled by network stack and some HW). But as nRF70 support all checksum offloads, advertise all types for both RX and TX. Upstream PR #: 80882 Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 3017425)
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
rlubos
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3017425~6..3017425 from #2221.