IPC: Unbound callback for ICMsg #7728
Annotations
12 errors, 11 warnings, and 10 notices
|
Check for PR description
Process completed with exit code 1.
|
|
Run Compliance Tests:
include/zephyr/ipc/ipc_service.h#L155
include/zephyr/ipc/ipc_service.h:155 trailing whitespace
|
|
Run Compliance Tests:
samples/subsys/ipc/ipc_service/icmsg/src/main.c#L152
samples/subsys/ipc/ipc_service/icmsg/src/main.c:152 do not use C99 // comments
|
|
Run Compliance Tests:
subsys/ipc/ipc_service/lib/icmsg.c#L173
subsys/ipc/ipc_service/lib/icmsg.c:173 "(foo*)" should be "(foo *)"
|
|
Run Compliance Tests:
subsys/ipc/ipc_service/lib/icmsg.c#L205
subsys/ipc/ipc_service/lib/icmsg.c:205 trailing whitespace
|
|
Run Compliance Tests:
subsys/ipc/ipc_service/lib/icmsg.c#L339
subsys/ipc/ipc_service/lib/icmsg.c:339 trailing whitespace
|
|
Run Compliance Tests
Process completed with exit code 5.
|
|
check-warns:
Identity.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
777754e68983a5d55478d516b6df6f9c16c7496d: author email (Radosław Koppel <[email protected]>) needs to match one of the signed-off-by entries.
20a84b32ecf725ce4b9be7b61bed6b920d8a8a73: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
a0e7692de060f9fd262917647c27e0db76c99b58: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
ed8bd0cedc4ae7eba0958e6e6ccc49e4adf3d12c: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
bb489572cb3d07d41269968bfa1f6597872d9716: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
ee34b8077ac0859fd081c9c6dabd12f6ef1c06f4: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
d9b8af37fb29911a92aea68e7f340f42cce2b014: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
b03c663ecd82632809e47ed646b661e2cd3fbadb: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
bcd2c5219c87d4abe329f7359064bea3885f58fe: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
32dc004f4d0d2f5315dad9275786fae653b49348: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
489c941f87beb5fdde96425d1017864659070946: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
49471c198270cba801a3113847c4cee7401f1a41: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
cdb111d66370d3d107e35c623eddbbc778b7732a: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
99cc53ea12e7e968cdfe54d2fc179f0ec9039d80: author email (Dominik Kilian <[email protected]>) needs to match one of the signed-off-by entries.
|
|
check-warns:
Gitlint.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
Commit 20a84b32ec:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Temporary workaround for PPR reset"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit a0e7692de0:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "FIx exception"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit ed8bd0cedc:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "ICBMsg fixes"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit bb489572cb:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Asserts and removed unused code"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit ee34b8077a:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Code cleanup"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit d9b8af37fb:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Fix infinite unbound"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit b03c663ecd:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Check unbound in icmsg sample"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit bcd2c5219c:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Working icmsg sample for nRF53"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit 32dc004f4d:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "All the code is in, ready to run it."
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit 489c941f87:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Draft of mbox callback handler"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit 49471c1982:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Draft of icmsg_open"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit cdb111d663:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "Add unbound DTS option and adjust pbuf for session handshake"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit 99cc53ea12:
1: UC2 Commit message does not contain a 'Sig
|
|
check-warns:
Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
TRAILING_WHITESPACE: trailing whitespace
File:include/zephyr/ipc/ipc_service.h
Line:155
LONG_LINE: line length of 113 exceeds 100 columns
File:include/zephyr/ipc/pbuf.h
Line:126
LONG_LINE: line length of 113 exceeds 100 columns
File:include/zephyr/ipc/pbuf.h
Line:127
C99_COMMENTS: do not use C99 // comments
File:samples/subsys/ipc/ipc_service/icmsg/src/main.c
Line:152
POINTER_LOCATION: "(foo*)" should be "(foo *)"
File:subsys/ipc/ipc_service/lib/icmsg.c
Line:173
TYPO_SPELLING: 'initalized' may be misspelled - perhaps 'initialized'?
File:subsys/ipc/ipc_service/lib/icmsg.c
Line:174
TRAILING_WHITESPACE: trailing whitespace
File:subsys/ipc/ipc_service/lib/icmsg.c
Line:205
TRAILING_WHITESPACE: trailing whitespace
File:subsys/ipc/ipc_service/lib/icmsg.c
Line:339
LONG_LINE: line length of 107 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/remote/src/remote.c
Line:134
LONG_LINE: line length of 105 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/remote/src/remote.c
Line:290
LONG_LINE: line length of 101 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:113
LONG_LINE_STRING: line length of 104 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:143
LONG_LINE: line length of 113 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:146
LONG_LINE: line length of 154 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:150
LONG_LINE: line length of 139 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:151
LONG_LINE: line length of 106 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:163
LONG_LINE_STRING: line length of 104 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:167
LONG_LINE: line length of 113 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:170
LONG_LINE: line length of 132 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:175
LONG_LINE: line length of 147 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:176
LONG_LINE: line length of 135 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:177
LONG_LINE_STRING: line length of 104 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:189
LONG_LINE: line length of 117 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:192
LONG_LINE: line length of 130 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:196
LONG_LINE: line length of 128 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:204
LONG_LINE_STRING: line length of 104 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:217
LONG_LINE: line length of 117 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:220
LONG_LINE: line length of 130 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:224
LONG_LINE: line length of 128 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:232
LONG_LINE_STRING: line length of 104 exceeds 100 columns
File:tests/subsys/ipc/ipc_sessions/src/main.c
Line:244
|
|
check-warns:
GitDiffCheck.txt#L1
Git conflict markers and whitespace errors are not allowed in added changes
ee34b8077ac0859fd081c9c6dabd12f6ef1c06f4: subsys/ipc/ipc_service/lib/icmsg.c:205: trailing whitespace.
ee34b8077ac0859fd081c9c6dabd12f6ef1c06f4: subsys/ipc/ipc_service/lib/icmsg.c:339: trailing whitespace.
489c941f87beb5fdde96425d1017864659070946: subsys/ipc/ipc_service/lib/icmsg.c:311: trailing whitespace.
99cc53ea12e7e968cdfe54d2fc179f0ec9039d80: include/zephyr/ipc/ipc_service.h:155: trailing whitespace.
|
|
check-warns
Process completed with exit code 1.
|
|
Run Compliance Tests:
include/zephyr/ipc/pbuf.h#L126
include/zephyr/ipc/pbuf.h:126 line length of 113 exceeds 100 columns
|
|
Run Compliance Tests:
include/zephyr/ipc/pbuf.h#L127
include/zephyr/ipc/pbuf.h:127 line length of 113 exceeds 100 columns
|
|
Run Compliance Tests:
subsys/ipc/ipc_service/lib/icmsg.c#L174
subsys/ipc/ipc_service/lib/icmsg.c:174 'initalized' may be misspelled - perhaps 'initialized'?
|
|
Run Compliance Tests:
tests/subsys/ipc/ipc_sessions/remote/src/remote.c#L134
tests/subsys/ipc/ipc_sessions/remote/src/remote.c:134 line length of 107 exceeds 100 columns
|
|
Run Compliance Tests:
tests/subsys/ipc/ipc_sessions/remote/src/remote.c#L290
tests/subsys/ipc/ipc_sessions/remote/src/remote.c:290 line length of 105 exceeds 100 columns
|
|
Run Compliance Tests:
tests/subsys/ipc/ipc_sessions/src/main.c#L113
tests/subsys/ipc/ipc_sessions/src/main.c:113 line length of 101 exceeds 100 columns
|
|
Run Compliance Tests:
tests/subsys/ipc/ipc_sessions/src/main.c#L143
tests/subsys/ipc/ipc_sessions/src/main.c:143 line length of 104 exceeds 100 columns
|
|
Run Compliance Tests:
tests/subsys/ipc/ipc_sessions/src/main.c#L146
tests/subsys/ipc/ipc_sessions/src/main.c:146 line length of 113 exceeds 100 columns
|
|
Run Compliance Tests:
tests/subsys/ipc/ipc_sessions/src/main.c#L150
tests/subsys/ipc/ipc_sessions/src/main.c:150 line length of 154 exceeds 100 columns
|
|
Run Compliance Tests:
tests/subsys/ipc/ipc_sessions/src/main.c#L151
tests/subsys/ipc/ipc_sessions/src/main.c:151 line length of 139 exceeds 100 columns
|
|
check-warns:
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
- *
+ *
File:include/zephyr/ipc/ipc_service.h
Line:156
You may want to run clang-format on this change:
- volatile uint32_t *rd_idx_loc; /* Address of the variable holding
- * index value of the first valid byte
- * in data[].
- */
- volatile uint32_t *handshake_loc;/* Address of the variable holding
- * handshake information.
- */
- volatile uint32_t *wr_idx_loc; /* Address of the variable holding
- * index value of the first free byte
- * in data[].
- */
- uint32_t dcache_alignment; /* CPU data cache line size in bytes.
- * Used for validation - TODO: To be
- * replaced by flags.
- */
- uint32_t len; /* Length of data[] in bytes. */
- uint8_t *data_loc; /* Location of the data[]. */
+ volatile uint32_t *rd_idx_loc; /* Address of the variable holding
+ * index value of the first valid byte
+ * in data[].
+ */
+ volatile uint32_t *handshake_loc; /* Address of the variable holding
+ * handshake information.
+ */
+ volatile uint32_t *wr_idx_loc; /* Address of the variable holding
+ * index value of the first free byte
+ * in data[].
+ */
+ uint32_t dcache_alignment; /* CPU data cache line size in bytes.
+ * Used for validation - TODO: To be
+ * replaced by flags.
+ */
+ uint32_t len; /* Length of data[] in bytes. */
+ uint8_t *data_loc; /* Location of the data[]. */
File:include/zephyr/ipc/pbuf.h
Line:67
You may want to run clang-format on this change:
-#define PBUF_CFG_INIT(mem_addr, size, dcache_align, use_handshake) \
-{ \
- .rd_idx_loc = (uint32_t *)(mem_addr), \
- .handshake_loc = use_handshake ? (uint32_t *)((uint8_t *)(mem_addr) + \
- _PBUF_IDX_SIZE) : NULL, \
- .wr_idx_loc = (uint32_t *)((uint8_t *)(mem_addr) + MAX(dcache_align, \
- (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE)), \
- .data_loc = (uint8_t *)((uint8_t *)(mem_addr) + \
- MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) + _PBUF_IDX_SIZE), \
- .len = (uint32_t)((uint32_t)(size) - MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) - \
- _PBUF_IDX_SIZE), \
- .dcache_alignment = (dcache_align), \
-}
+#define PBUF_CFG_INIT(mem_addr, size, dcache_align, use_handshake) \
+ { \
+ .rd_idx_loc = (uint32_t *)(mem_addr), \
+ .handshake_loc = use_handshake \
+ ? (uint32_t *)((uint8_t *)(mem_addr) + _PBUF_IDX_SIZE) \
+ : NULL, \
+ .wr_idx_loc = \
+ (uint32_t *)((uint8_t *)(mem_addr) + \
+ MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE)), \
+ .data_loc = \
+ (uint8_t *)((uint8_t *)(mem_addr) + \
+ MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) + \
+ _PBUF_IDX_SIZE), \
+ .len = (uint32_t)((uint32_t)(size) - \
+ MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) - \
+ _PBUF_IDX_SIZE), \
+ .dcache_alignment = (dcache_align), \
+ }
File:include/zephyr/ipc/pbuf.h
Line:131
You may want to run clang-format on this change:
-#define PBUF_DEFINE(name, mem_addr, size, dcache_align, use_handshake, compatibility) \
- BUILD_ASSERT(dcache_align >= 0, \
- "Cache line size must be non negative."); \
- BU
|
|
Run Compliance Tests:
include/zephyr/ipc/ipc_service.h#L156
include/zephyr/ipc/ipc_service.h:156
- *
+ *
|
|
Run Compliance Tests:
include/zephyr/ipc/pbuf.h#L67
include/zephyr/ipc/pbuf.h:67
- volatile uint32_t *rd_idx_loc; /* Address of the variable holding
- * index value of the first valid byte
- * in data[].
- */
- volatile uint32_t *handshake_loc;/* Address of the variable holding
- * handshake information.
- */
- volatile uint32_t *wr_idx_loc; /* Address of the variable holding
- * index value of the first free byte
- * in data[].
- */
- uint32_t dcache_alignment; /* CPU data cache line size in bytes.
- * Used for validation - TODO: To be
- * replaced by flags.
- */
- uint32_t len; /* Length of data[] in bytes. */
- uint8_t *data_loc; /* Location of the data[]. */
+ volatile uint32_t *rd_idx_loc; /* Address of the variable holding
+ * index value of the first valid byte
+ * in data[].
+ */
+ volatile uint32_t *handshake_loc; /* Address of the variable holding
+ * handshake information.
+ */
+ volatile uint32_t *wr_idx_loc; /* Address of the variable holding
+ * index value of the first free byte
+ * in data[].
+ */
+ uint32_t dcache_alignment; /* CPU data cache line size in bytes.
+ * Used for validation - TODO: To be
+ * replaced by flags.
+ */
+ uint32_t len; /* Length of data[] in bytes. */
+ uint8_t *data_loc; /* Location of the data[]. */
|
|
Run Compliance Tests:
include/zephyr/ipc/pbuf.h#L131
include/zephyr/ipc/pbuf.h:131
-#define PBUF_CFG_INIT(mem_addr, size, dcache_align, use_handshake) \
-{ \
- .rd_idx_loc = (uint32_t *)(mem_addr), \
- .handshake_loc = use_handshake ? (uint32_t *)((uint8_t *)(mem_addr) + \
- _PBUF_IDX_SIZE) : NULL, \
- .wr_idx_loc = (uint32_t *)((uint8_t *)(mem_addr) + MAX(dcache_align, \
- (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE)), \
- .data_loc = (uint8_t *)((uint8_t *)(mem_addr) + \
- MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) + _PBUF_IDX_SIZE), \
- .len = (uint32_t)((uint32_t)(size) - MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) - \
- _PBUF_IDX_SIZE), \
- .dcache_alignment = (dcache_align), \
-}
+#define PBUF_CFG_INIT(mem_addr, size, dcache_align, use_handshake) \
+ { \
+ .rd_idx_loc = (uint32_t *)(mem_addr), \
+ .handshake_loc = use_handshake \
+ ? (uint32_t *)((uint8_t *)(mem_addr) + _PBUF_IDX_SIZE) \
+ : NULL, \
+ .wr_idx_loc = \
+ (uint32_t *)((uint8_t *)(mem_addr) + \
+ MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE)), \
+ .data_loc = \
+ (uint8_t *)((uint8_t *)(mem_addr) + \
+ MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) + \
+ _PBUF_IDX_SIZE), \
+ .len = (uint32_t)((uint32_t)(size) - \
+ MAX(dcache_align, (use_handshake ? 2 : 1) * _PBUF_IDX_SIZE) - \
+ _PBUF_IDX_SIZE), \
+ .dcache_alignment = (dcache_align), \
+ }
|
|
Run Compliance Tests:
include/zephyr/ipc/pbuf.h#L165
include/zephyr/ipc/pbuf.h:165
-#define PBUF_DEFINE(name, mem_addr, size, dcache_align, use_handshake, compatibility) \
- BUILD_ASSERT(dcache_align >= 0, \
- "Cache line size must be non negative."); \
- BUILD_ASSERT((size) > 0 && IS_PTR_ALIGNED_BYTES(size, _PBUF_IDX_SIZE), \
- "Incorrect size."); \
- BUILD_ASSERT(IS_PTR_ALIGNED_BYTES(mem_addr, MAX(dcache_align, _PBUF_IDX_SIZE)), \
- "Misaligned memory."); \
- BUILD_ASSERT(size >= (MAX(dcache_align, _PBUF_IDX_SIZE) + _PBUF_IDX_SIZE + \
- _PBUF_MIN_DATA_LEN), "Insufficient size."); \
- BUILD_ASSERT(!(compatibility) || (dcache_align) >= 8, \
- "Data cache alignment must be at least 8 if compatibility is enabled.");\
- static PBUF_MAYBE_CONST struct pbuf_cfg cfg_##name = \
- PBUF_CFG_INIT(mem_addr, size, dcache_align, use_handshake); \
- static struct pbuf name = { \
- .cfg = &cfg_##name, \
+#define PBUF_DEFINE(name, mem_addr, size, dcache_align, use_handshake, compatibility) \
+ BUILD_ASSERT(dcache_align >= 0, "Cache line size must be non negative."); \
+ BUILD_ASSERT((size) > 0 && IS_PTR_ALIGNED_BYTES(size, _PBUF_IDX_SIZE), "Incorrect size."); \
+ BUILD_ASSERT(IS_PTR_ALIGNED_BYTES(mem_addr, MAX(dcache_align, _PBUF_IDX_SIZE)), \
+ "Misaligned memory."); \
+ BUILD_ASSERT( \
+ size >= (MAX(dcache_align, _PBUF_IDX_SIZE) + _PBUF_IDX_SIZE + _PBUF_MIN_DATA_LEN), \
+ "Insufficient size."); \
+ BUILD_ASSERT(!(compatibility) || (dcache_align) >= 8, \
+ "Data cache alignment must be at least 8 if compatibility is enabled."); \
+ static PBUF_MAYBE_CONST struct pbuf_cfg cfg_##name = \
+ PBUF_CFG_INIT(mem_addr, size, dcache_align, use_handshake); \
+ static struct pbuf name = { \
+ .cfg = &cfg_##name, \
|
|
Run Compliance Tests:
samples/subsys/ipc/ipc_service/icmsg/src/main.c#L140
samples/subsys/ipc/ipc_service/icmsg/src/main.c:140
- .cb = {
- .bound = ep_bound,
- .unbound = ep_unbound,
- .received = ep_recv,
- .error = ep_error,
- },
+ .cb =
+ {
+ .bound = ep_bound,
+ .unbound = ep_unbound,
+ .received = ep_recv,
+ .error = ep_error,
+ },
|
|
Run Compliance Tests:
samples/subsys/ipc/ipc_service/icmsg/src/main.c#L153
samples/subsys/ipc/ipc_service/icmsg/src/main.c:153
- //nrf53_cpunet_enable(true); printk("sample");
+ // nrf53_cpunet_enable(true); printk("sample");
|
|
Run Compliance Tests:
samples/subsys/ipc/ipc_service/icmsg/src/main.c#L197
samples/subsys/ipc/ipc_service/icmsg/src/main.c:197
- nrf53_cpunet_enable(true); printk("sample 2");
+ nrf53_cpunet_enable(true);
+ printk("sample 2");
|
|
Run Compliance Tests:
samples/subsys/ipc/ipc_service/icmsg/src/main.c#L230
samples/subsys/ipc/ipc_service/icmsg/src/main.c:230
- nrf53_cpunet_enable(true); printk("sample 2");
+ nrf53_cpunet_enable(true);
+ printk("sample 2");
|
|
Run Compliance Tests:
subsys/ipc/ipc_service/backends/ipc_icbmsg.c#L1456
subsys/ipc/ipc_service/backends/ipc_icbmsg.c:1456
-#define DEFINE_BACKEND_DEVICE(i) \
- SYS_BITARRAY_DEFINE_STATIC(tx_usage_bitmap_##i, DT_INST_PROP(i, tx_blocks)); \
- SYS_BITARRAY_DEFINE_STATIC(rx_hold_bitmap_##i, DT_INST_PROP(i, rx_blocks)); \
- PBUF_DEFINE(tx_icbmsg_pb_##i, \
- GET_MEM_ADDR_INST(i, tx), \
- GET_ICMSG_SIZE_INST(i, tx, rx), \
- GET_CACHE_ALIGNMENT(i), 0, 0); \
- PBUF_DEFINE(rx_icbmsg_pb_##i, \
- GET_MEM_ADDR_INST(i, rx), \
- GET_ICMSG_SIZE_INST(i, rx, tx), \
- GET_CACHE_ALIGNMENT(i), 0, 0); \
- static struct backend_data backend_data_##i = { \
- .control_data = { \
- .tx_pb = &tx_icbmsg_pb_##i, \
- .rx_pb = &rx_icbmsg_pb_##i, \
- } \
- }; \
- static MAYBE_CONST struct icbmsg_config backend_config_##i = \
- { \
- .control_config = { \
- .mbox_tx = MBOX_DT_SPEC_INST_GET(i, tx), \
- .mbox_rx = MBOX_DT_SPEC_INST_GET(i, rx), \
- .unbound_mode = ICMSG_UNBOUND_MODE_DISABLE, /* TODO: */ \
- }, \
- .tx = { \
- .blocks_ptr = (uint8_t *)GET_BLOCKS_ADDR_INST(i, tx, rx), \
- .block_count = DT_INST_PROP(i, tx_blocks), \
- .block_size = GET_BLOCK_SIZE_INST(i, tx, rx), \
- }, \
- .rx = { \
- .blocks_ptr = (uint8_t *)GET_BLOCKS_ADDR_INST(i, rx, tx), \
- .block_count = DT_INST_PROP(i, rx_blocks), \
- .block_size = GET_BLOCK_SIZE_INST(i, rx, tx), \
- }, \
- .tx_usage_bitmap = &tx_usage_bitmap_##i, \
- .rx_hold_bitmap = &rx_hold_bitmap_##i, \
- }; \
- BUILD_ASSERT(IS_POWER_OF_TWO(GET_CACHE_ALIGNMENT(i)), \
- "This module supports only power of two cache alignment"); \
- BUILD_ASSERT((GET_BLOCK_SIZE_INST(i, tx, rx) >= GET_CACHE_ALIGNMENT(i)) && \
- (GET_BLOCK_SIZE_INST(i, tx, rx) < \
- GET_MEM_SIZE_INST(i, tx)), \
- "TX region is too small for provided number of blocks"); \
- BUILD_ASSERT((GET_BLOCK_SIZE_INST(i, rx, tx) >= GET_CACHE_ALIGNMENT(i)) && \
- (GET_BLOCK_SIZE_INST(i, rx, tx) < \
- GET_MEM_SIZE_INST(i, rx)), \
- "RX region is too small for provided number of blocks"); \
- BUILD_ASSERT(DT_INST_PROP(i, rx_blocks) <= 256, "Too many RX blocks"); \
- BUILD_ASSERT(DT_INST_PROP(i, tx_blocks) <= 256, "Too many TX blocks"); \
- DEVICE_DT_INST_DEFINE(i, \
- &backend_init, \
- NULL, \
- &backend_data_##i, \
- &backend_config_##i, \
- POST_KERNEL, \
- CONFIG_IPC_SERVICE_REG_BACKEND_PRIORITY, \
- &backend_ops);
+#define DEFINE_BACKEND_DEVICE(i) \
+ SYS_BITARRAY_DEFINE_STATIC(tx_usage_bitmap_##i, DT_INST_PROP(i, tx_blocks)); \
+ SYS_BITARRAY_DEFINE_STATIC(rx_hold_bitmap_##i, DT_INST_PROP(i, rx_blocks)); \
+ PBUF_DEFINE(tx_icbmsg_pb_##i, GET_MEM_ADDR_INST(i, tx), GET_ICMSG_SIZE_INST(i, tx, rx), \
+ GET_CACHE_ALIGNMENT(i), 0, 0); \
+ PBUF_DEFINE(rx_icbmsg_pb_##i, GET_MEM_ADDR_INST(i, rx), GET_ICMSG_SIZE_INST(i, rx, tx), \
+ GET_CACHE_ALIGNMENT(i), 0, 0); \
+ static struct backend_data backend_data_##i = {.control_data = { \
+ .tx_pb = &tx_icbmsg_pb_##i, \
+ .rx_pb = &rx_icbmsg_pb_##i, \
+ }}; \
+ static MAYBE_CONST struct icbmsg_config backend_config_##i = { \
+ .control_config = \
+ { \
+ .mbox_tx = MBOX_DT_SPEC_INST_GET(i, tx), \
+ .mbox_rx = MBOX_DT_SPEC_INST_GET(i, rx), \
+ .unbound_mode = ICMSG_UNBOUND_MODE_DISABLE, /* TODO: */ \
+ }, \
|
|
Run Compliance Tests:
subsys/ipc/ipc_service/backends/ipc_icmsg.c#L104
subsys/ipc/ipc_service/backends/ipc_icmsg.c:104
-#define DEFINE_BACKEND_DEVICE(i) \
- static const struct icmsg_config_t backend_config_##i = { \
- .mbox_tx = MBOX_DT_SPEC_INST_GET(i, tx), \
- .mbox_rx = MBOX_DT_SPEC_INST_GET(i, rx), \
- .unbound_mode = UNBOUND_MODE(i), \
- }; \
- \
- PBUF_DEFINE(tx_pb_##i, \
- DT_REG_ADDR(DT_INST_PHANDLE(i, tx_region)), \
- DT_REG_SIZE(DT_INST_PHANDLE(i, tx_region)), \
- DT_INST_PROP_OR(i, dcache_alignment, 0), \
- UNBOUND_MODE(i) != ICMSG_UNBOUND_MODE_DISABLE, \
- UNBOUND_MODE(i) == ICMSG_UNBOUND_MODE_DETECT); \
- PBUF_DEFINE(rx_pb_##i, \
- DT_REG_ADDR(DT_INST_PHANDLE(i, rx_region)), \
- DT_REG_SIZE(DT_INST_PHANDLE(i, rx_region)), \
- DT_INST_PROP_OR(i, dcache_alignment, 0), \
- UNBOUND_MODE(i) != ICMSG_UNBOUND_MODE_DISABLE, \
- UNBOUND_MODE(i) == ICMSG_UNBOUND_MODE_DETECT); \
- \
- BUILD_ASSERT(UNBOUND_MODE(i) != ICMSG_UNBOUND_MODE_DISABLE || \
- IS_ENABLED(CONFIG_IPC_SERVICE_ICMSG_UNBOUND_DISABLED_ALLOWED), \
- "Unbound mode \"disabled\" is was forbidden in Kconfig."); \
- \
- BUILD_ASSERT(UNBOUND_MODE(i) != ICMSG_UNBOUND_MODE_ENABLE || \
- IS_ENABLED(CONFIG_IPC_SERVICE_ICMSG_UNBOUND_ENABLED_ALLOWED), \
- "Unbound mode \"enabled\" is was forbidden in Kconfig."); \
- \
- BUILD_ASSERT(UNBOUND_MODE(i) != ICMSG_UNBOUND_MODE_DETECT || \
- IS_ENABLED(CONFIG_IPC_SERVICE_ICMSG_UNBOUND_DETECT_ALLOWED), \
- "Unbound mode \"detect\" is was forbidden in Kconfig."); \
- \
- static struct icmsg_data_t backend_data_##i = { \
- .tx_pb = &tx_pb_##i, \
- .rx_pb = &rx_pb_##i, \
- }; \
- \
- DEVICE_DT_INST_DEFINE(i, \
- &backend_init, \
- NULL, \
- &backend_data_##i, \
- &backend_config_##i, \
- POST_KERNEL, \
- CONFIG_IPC_SERVICE_REG_BACKEND_PRIORITY, \
- &backend_ops);
+#define DEFINE_BACKEND_DEVICE(i) \
+ static const struct icmsg_config_t backend_config_##i = { \
+ .mbox_tx = MBOX_DT_SPEC_INST_GET(i, tx), \
+ .mbox_rx = MBOX_DT_SPEC_INST_GET(i, rx), \
+ .unbound_mode = UNBOUND_MODE(i), \
+ }; \
+ \
+ PBUF_DEFINE(tx_pb_##i, DT_REG_ADDR(DT_INST_PHANDLE(i, tx_region)), \
+ DT_REG_SIZE(DT_INST_PHANDLE(i, tx_region)), \
+ DT_INST_PROP_OR(i, dcache_alignment, 0), \
+ UNBOUND_MODE(i) != ICMSG_UNBOUND_MODE_DISABLE, \
+ UNBOUND_MODE(i) == ICMSG_UNBOUND_MODE_DETECT); \
+ PBUF_DEFINE(rx_pb_##i, DT_REG_ADDR(DT_INST_PHANDLE(i, rx_region)), \
+ DT_REG_SIZE(DT_INST_PHANDLE(i, rx_region)), \
+ DT_INST_PROP_OR(i, dcache_alignment, 0), \
+ UNBOUND_MODE(i) != ICMSG_UNBOUND_MODE_DISABLE, \
+ UNBOUND_MODE(i) == ICMSG_UNBOUND_MODE_DETECT); \
+ \
+ BUILD_ASSERT(UNBOUND_MODE(i) != ICMSG_UNBOUND_MODE_DISABLE || \
+ IS_ENABLED(CONFIG_IPC_SERVICE_ICMSG_UNBOUND_DISABLED_ALLOWED), \
+ "Unbound mode \"disabled\" is was forbidden in Kconfig."); \
+ \
+ BUILD_ASSERT(UNBOUND_MODE(i) != ICMSG_UNBOUND_MODE_ENABLE || \
+ IS_ENABLED(CONFIG_IPC_SERVICE_ICMSG_UNBOUND_ENABL
|
Loading