-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf_modem doc update for nRF9161 #1086
Conversation
9cc8e67
to
aea3dd3
Compare
9bf50ae
to
2f1103b
Compare
2f1103b
to
71a85db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, just a minor comment.
nrf_modem/README.rst
Outdated
@@ -3,7 +3,7 @@ | |||
Modem library | |||
############# | |||
|
|||
The Modem library is the primary interface for operating the nRF9160 modem, establishing the LTE-M and NB-IoT connections, and receiving the position data (GPS). | |||
The Modem library is the primary interface for operating the cellular modem, establishing the LTE-M and NB-IoT connections, and receiving the position data (GPS). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have said the nRF91 series modem
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, we could use the "nRF91 Series modem" term here. Could see similar terms used in the infocenter docs for nRF9160.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Add support for nRF9161 to documentation. Co-authored-by: divya pillai <[email protected]> Signed-off-by: Eivind Jølsgard <[email protected]>
71a85db
to
d5aca59
Compare
Depends on #1079