-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove child/parent image support #19283
base: main
Are you sure you want to change the base?
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 3 projects with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 05bc31fb2c127f4d711e41a0e3950d2f496a84c0 more detailssdk-nrf:
mcuboot:
matter:
zephyr:
Github labels
List of changed files detected by CI (119)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
fc29731
to
ee39911
Compare
ee39911
to
fa54878
Compare
fa54878
to
4a83180
Compare
4a83180
to
5cb647c
Compare
5cb647c
to
740d4de
Compare
cb3487d
to
d298017
Compare
Removes support for child/parent image from these repos Signed-off-by: Jamie McCrae <[email protected]>
Removes support for child/parent image Signed-off-by: Jamie McCrae <[email protected]>
97bf992
to
05bc31f
Compare
@tejlmand @nrfconnect/ncs-nrf-cloud @nrfconnect/ncs-si-muffin @nrfconnect/ncs-audio @nrfconnect/ncs-aegir @nrfconnect/ncs-dragoon @nrfconnect/ncs-si-bluebagel @nrfconnect/ncs-co-networking @nrfconnect/ncs-iot-oulu @nrfconnect/ncs-doc-leads @nrfconnect/ncs-vestavind-doc @nrfconnect/ncs-cia please review |
The listing below describes how to leverage this functionality, where ``ACI_NAME`` is the name of the child image to which the configuration will be applied. | ||
|
||
.. literalinclude:: ../../../../cmake/multi_image.cmake | ||
:language: c | ||
:start-at: It is possible for a sample to use a custom set of Kconfig fragments for a | ||
:end-before: set(ACI_CONF_DIR ${config_dir}/child_image) | ||
|
||
When you are using :ref:`app_build_additions_build_types` and the configuration name has been inferred, the child image Kconfig overlay file is searched at :file:`child_image/<ACI_NAME>_<name>.conf`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the entire page or remove it, given the note at the top of the page.
Other pages that need to be updated:
- config_and_build_system.rst - sections "Child images" and "Multi-image builds"
- multi_image_nrf5340.rst - entire page needs to be reviewed or removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am deferring this to another PR as the changes are quite extensive and it's going to take a bit of time and a lot of CI attempts to get the doc build to actually work, the change here is just for the build systems parts. Can see the doc changes in this branch here: main...nordicjm:sdk-nrf:byebyechildparent_doc which does not build documentation successfully which is why I removed it
Removes support for this deprecated feature
test_sdk_mcuboot: sdk-nrf-19283
test_rs: PR-1443
test_fem: PR-1443