Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phantomjs2.0 #63

Open
tanhaoqin opened this issue May 18, 2015 · 7 comments
Open

Phantomjs2.0 #63

tanhaoqin opened this issue May 18, 2015 · 7 comments

Comments

@tanhaoqin
Copy link

PhantomJS phantom.args.length method call is outdated.

TypeError: undefined is not an object (evaluating 'phantom.args.length')

pjscrape.js:877 in global code

@nrabinowitz
Copy link
Owner

Will consider this PR when I package for npm - otherwise, there's no easy way to ensure the user has the right Phantom version, and I don't want to support both 2.x and 1.x if I can help it.

@daniel-lucio
Copy link

So, will your project run on PhanthomJS 2?

@jpz
Copy link

jpz commented Sep 27, 2015

Broken here also.

@daniel-lucio
Copy link

I can confirm the patch works fine

@jpz
Copy link

jpz commented Sep 27, 2015

Pull request 64 does run fine - thanks.

@daniel-lucio
Copy link

I am trying a little example using phanthom2 and it gets like a zombie. The debug does not give any useful information.

Phanthom2 examples (no pjscrape) works okay.

@mihutz92
Copy link

mihutz92 commented Jul 12, 2017

Hi! So, current version of pjscrape works only with phantomJS 2 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants