feat: Make archiving optional #30
Conversation
baolsen
force-pushed
the
local-archive
branch
from
d4ad0f5 to
d195edf
Compare
baolsen
force-pushed
the
local-archive
branch
from
d195edf to
9d671a1
Compare
There was a problem hiding this comment.
@baolsen Thanks for the suggestion!
To keep the backward compatibility, how about making both var.output_path and var.source_dir optional by setting default values? Currently both variables are required, so module users need to specify output_path argument even if they don't use it.
baolsen
force-pushed
the
local-archive
branch
from
b502b00 to
f37528c
Compare
|
Hey @nozaq Thanks for the feedback. I considered this initially... Setting a default implies they are optional parameters. If both Looking at the official provider, the deployment-related variables are all optional (but logically at least one should be specified by the user). Anyway, I've added S3 deployment as an alternative option. In retrospect, I guess that won't solve the issue either. Eg If the S3 variables are also defaulted then the deployment could still try to create a lambda with no code. Perhaps there is no way around it right now; at least, without adding complex validation rules supported in newer TF versions. I'm not sure if this would even be a good idea. Anyway, let me know what you think. I'll leave the S3 code here for your consideration. |
|
@nozaq ready for review :) |
|
@nozaq , bump :) |
Closes #29