This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
Check tweetnacl C version #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchalkias
reviewed
Nov 9, 2022
README.md
Outdated
| |Zebra | V | V | V | V | V | V | X | X | X | V | V | V | | ||
| --------------------------------------------------------------- | ||
| ``` | ||
| Note that wolfSSL can return three options, verified (V), not verfied | ||
| (X) and error in verification procedure (E). |
There was a problem hiding this comment.
It's highly possible that this is true in other implementations as well, but iirc we used X for both errors and unverified sigs. We can make a comment to track those and update holistically (for the other implementations too) in another PR, but in this PR use X.
There was a problem hiding this comment.
Ok. Expect to add a few more libraries. Will update this on the next addition.
Also use only X and V following review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.