Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected-react-router v6 breaking this app #75

Open
deksden opened this issue Jan 16, 2019 · 3 comments
Open

Connected-react-router v6 breaking this app #75

deksden opened this issue Jan 16, 2019 · 3 comments

Comments

@deksden
Copy link

deksden commented Jan 16, 2019

Migrating from v4 to v5 (v6) is breaking app.

Here is FAQ with instruction how to migrate:
https://github.com/supasate/connected-react-router/blob/master/FAQ.md#how-to-migrate-from-v4-to-v5

@vchouhan
Copy link

vchouhan commented Jan 19, 2019

"connected-react-router": "^6.2.1",
"react-redux": "^6.0.0",

Tried running with the above versions of connected-react-router and react-redux and the app keeps throwing the following error.
Could not find router reducer in state tree, it must be mounted under "router". After updating the Migration to v5 and v6 the app works but when I add a customContext to the provider and connectedRouter the following error.
Could not find "store" in the context of "Connect(Home)". Either wrap the root component in a <Provider>, or pass a custom React context provider to <Provider> and the corresponding React context consumer to Connect(Home) in connect options.
I've opened a issue on the connected-react-router repo (supasate/connected-react-router#241)

@dcsan
Copy link

dcsan commented Jan 24, 2019

yeah I hit this exact problem. the joys of the react ecosystem thrash, everything breaks 15 minutes later.

@notrab
Copy link
Owner

notrab commented Jan 24, 2019

@vchouhan have you seen #71 ?

It might be worth checking out that branch, confirming it works and then we can push it into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants