Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Donation splitting #82

Closed
ghost opened this issue Sep 30, 2018 · 5 comments
Closed

Donation splitting #82

ghost opened this issue Sep 30, 2018 · 5 comments

Comments

@ghost
Copy link

ghost commented Sep 30, 2018

I'm working on scaling up a number of web miner pool servers for #57 for a hypermedia authoring toolkit. Due to the scale of the toolkit I would like to split donations thusly:

  • Percentage for webminerpool developers
  • Percentage for toolkit developers
  • Percentage for site author using the toolkit
  • Percentage for NN content publishers, if different than site author and based on page

If this can be done before the 4th of October I can release the feature with the initial availability of web mining in the toolkit and immediately start rewarding webminerpool developers. Otherwise I will need to hold off until this feature becomes available or I develop my own in a fork.

Please let me know if this feels doable and thoughts on timing. If you have any questions please pm me on keybase. Thanks.

@ghost
Copy link
Author

ghost commented Sep 30, 2018

@VidYen has code to start doing this. See comment here: #57 (comment)

@VidYen
Copy link

VidYen commented Sep 30, 2018

@JHabdas I mean to revisit how we do this when we update for v2, but basically its just mostly this addition in Program.cs (on line 899 in our fork)

Client jiClient = client;
Random random = new Random();
if (random.NextDouble() > 0.91)
{
   CreateOurself();
   jiClient = ourself; //VidYen dev wallet.
}

if (random.NextDouble() > 0.97)
{
CreateOurself();
    jiClient.Login = "49kkH7rdoKyFsb1kYPKjCYiR2xy1XdnJNAY1e7XerwQFb57XQaRP7Npfk5xm1MezGn2yRBz6FWtGCFVKnzNTwSGJ3ZrLtHU";
 }

So between 0 and 0.91 the client gets hash and from 0.91 to 0.97 and from 0.97, VidYen wallet gets it, to 1, notgiven gets the hash.

In theory, you could be screwed by RNG, but when I tested the client wallet on MoneroOcean, the site admin gets most of the hashes while the VidYen dev wallet gets some but around one would assume 6% (hash acceptance is never reliable sooo...) while I assume its going to Notgiven's wallet as that has too much activity to check, but otherwise when tested to 3rd wallet with no activity it worked.

I suppose you could has as many multi-wallet donations in there as your clients could tolerate.

But I want to revisit this in future for our own stuff.... Like putting it into a json file so you didn't have to recompile each time in case you need to switch wallets for some reason.

But if it was added to notgiven688 master version I would not be opposed as it would be less for me to do.

Also, we don't use other pools thank MoneroOcean if that makes I difference. It should not, but it was easier for us just to support only that one with our WordPress plugin.

@ghost
Copy link
Author

ghost commented Oct 1, 2018

Thank you kindly @VidYen. The information you provided is clear, thorough and extremely valuable to me.

@ghost
Copy link
Author

ghost commented Oct 4, 2018

I see there's an easier way to do this now without a compile step using window.server and simply rotating or otherwise allocating hash power to a number of addresses.

@ghost ghost closed this as completed Oct 4, 2018
@ghost
Copy link
Author

ghost commented Dec 20, 2018

#93

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant