native/macos: Fixes setNeedsDisplay call on arm macs #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-fl3
reviewed
Aug 12, 2024
| // YES to setNeedsDisplay - send a no argument message | ||
| // https://stackoverflow.com/questions/6120614/passing-primitives-through-performselectoronmainthread | ||
| // It seems that the same thing applies to [NSTimer timerWithTimeInterval:...] | ||
| extern "C" fn set_needs_display_hack(this: &Object, _: Sel) { |
There was a problem hiding this comment.
shame on you, apple, I wish we did not need to do this :(
|
@birhburh confirmed that I confirmed Nice! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for: #470 (comment)
@brettchalupa, can you please recheck now
And with metal also, please, just to be sure (
cargo run --example quad metal)