How to use "mod crit type on target condition" attribute?

[FrostBuild]

I can't figure out how to use "mod crit type on target condition" attribute.

I tried :
"no_dot=1 condition=TF_COND_GAS crit_type=2"
"no_dot=1 condition=TFCond_Gas crit_type=2"
"no_dot=1 condition=GAS crit_type=2"
"no_dot=1 condition=Gas crit_type=2"
"condition=TF_COND_GAS crit_type=2"
"condition=TFCond_Gas crit_type=2"

I don't know if I'm using the attribute wrong or if it doesn't work.
Thank you in advance for your reply.

[nosoop]

It would be TF_COND_GAS. I can confirm that it (condition=TF_COND_GAS crit_type=2) works when applied to either the Pyro's primary or melee weapons.
Keep in mind that the gas condition is cleared once the target is ignited, so it'll only crit on the weapon hit that causes the ignition.

If it's a specific weapon you're having trouble with, do note that.

[FrostBuild]

I tried it on a fire axe in this configuration but nothing happened.
"2"
{
"#custom_attributes"
{
"mod crit type on target condition" "condition=TF_COND_GAS crit_type=2"
}
}

[FrostBuild]

The configuration is from NotnHeavy's Attribute Manager, otherwise the debugger shows this.
---- Attributes for entity 770 (TF_WEAPON_FIREAXE)
mod crit type on target condition = 'condition=TF_COND_GAS crit_type=2'

[nosoop]

Debugger says it's applied, so it's a matter of whether or not the plugin is loaded.

Make sure the damage hooks are also up to date.

[FrostBuild]

OnTakeDamage version is 1.3.3.1, otherwise I also tried "tf_custom_attributes_manager" with the same result.

[nosoop]

No idea then; check your plugin list. You may need to do some print debugging to see if the plugin is hitting any of the code paths.

The damage hook doesn't allow mid-stops so it's unlikely that another plugin would interfere that way, but another plugin may override the crit result after this one gets processed.

[FrostBuild]

So, after reinstalling, I found out that the sigsegv-mvm plugin somehow overrides this attribute. I'll see if I can solve it somehow through the configuration. Anyway, thanks for the assistance.