Upon reconnecting, the network icon stays red

[jeroenptrs]

Expected Behavior

Icon goes back to green

Current Behavior

Icon stays red

Steps to Reproduce

1. Connect
2. internet off and back on
3. See new blocks coming in
4. Icon stays red

Possible Solution

Additional context

Your Environment

• nOS Client version used: dev branch
• Environment name and version
  • Node version:
  • NPM version:
  • Yarn version:
• Operating System and version (desktop or mobile):

[mhuggins]

We're only polling every 10 seconds. Did it still stay red after 10+ seconds of waiting?

[jeroenptrs]

Yerp, it stayed red even when new blocks were coming in

[mhuggins]

Ahh, I know why. We're always passing the action data & error to the component. This, combined with the fact that spunky doesn't clear out prior errors/data unless a new error/data takes its place, means that old errors will still be passed to that tooltip component.

With that in mind, we need to modify the behavior to use the withProgress HOC, which can conditionally pass the data (if progress is not FAILED) or error (if progress is FAILED) to the component.

[DalderupMaurice]

Isn't this fixed rn? @mhuggins

[DalderupMaurice]

Ah nvm - tested it, disconnecting and reconnecting internet connection doesn't reconnect to the nodes. Can't open the wallet afterwards and the icon remains red besides new blocks coming in