Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup time is too long #33

Open
nortakales opened this issue Dec 13, 2023 · 2 comments
Open

Startup time is too long #33

nortakales opened this issue Dec 13, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@nortakales
Copy link
Owner

It was mentioned in #32 that startup time for the extension can be upwards of 20 seconds. I'm personally seeing around 15 seconds. This is too long and should be investigated.

@nortakales nortakales added the bug Something isn't working label Dec 13, 2023
@tylerlaprade
Copy link

image This is by far my slowest extension, but it's so useful that I don't want to disable it. Based on the linked issue above, if this is indeed due to the currency exchange rate API, I'm happy to just disable that if possible since I tend not to do anything with currencies.

@nortakales
Copy link
Owner Author

At some point I had added some instrumentation to see where the time was being spent during startup, but I don't remember finding anything conclusive. That was quite a long time ago at this point though, so I definitely need to tackle that again. It can't be from fetching the exchange rates because the vast majority of the time it will grab them from a local cache. Especially if you just reload VSCode, it will definitely have cached values (but still takes a while for the extension to start).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants