Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with both options enabled #14

Open
Tiagoquix opened this issue Mar 18, 2024 · 7 comments
Open

Problem with both options enabled #14

Tiagoquix opened this issue Mar 18, 2024 · 7 comments

Comments

@Tiagoquix
Copy link
Contributor

It seems that since b977ec6, having both options (redirect to original + disable lightbox) enabled will make the image inside the lightbox, on the first click, to go to preview.redd.it, and will only go to i.reddi.it after a reload.

@nopperl
Copy link
Owner

nopperl commented Mar 19, 2024

I can't reproduce this... if I click on an image, the i.redd.it URL is directly loaded as expected. On which URL does it happen for you?

@Tiagoquix
Copy link
Contributor Author

I can't reproduce this... if I click on an image, the i.redd.it URL is directly loaded as expected. On which URL does it happen for you?

It happens randomly. Try clearing your browser cache to see if it happens to you.

@ViRGEdx
Copy link

ViRGEdx commented Mar 22, 2024

Okay, I must be the dumbest moron in the universe. But where is the settings page for these features? Firefox does not show an options page as being available for this plugin.

@Tiagoquix
Copy link
Contributor Author

You have to click the Extensions icon on the toolbar and then click on the extension itself.

@Tiagoquix
Copy link
Contributor Author

About preview.redd.it, when I mouse-over an image in a /comments/ subpage, the URL in the bottom-left corner shows preview.redd.it. If I click the image, that's where I go. If I then reload the page, I get i.redd.it.

As I said in the other issue, we should always detect preview.redd.it (and external-preview.redd.it) and force a reload to go to i.redd.it.

@nopperl
Copy link
Owner

nopperl commented Aug 1, 2024

Hm, I'm not able to reproduce that @Tiagoquix. As an example: https://www.reddit.com/r/pics/comments/1eh7owm/olympic_shooting_silver_medalist_yusuf_dike%C3%A7/#lightbox
If I click on the image, the i.redd.it URL is loaded. Could you try this example?

@Tiagoquix
Copy link
Contributor Author

In the example you provided, I get i.redd.it normally. It's a strange issue, because it does not happen all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants