Feature/get profile by username

src/main/kotlin/io/github/nomisrev/DomainError.kt

@@ -18,6 +18,8 @@ data class IncorrectInput(val errors: NonEmptyList<InvalidField>) : ValidationEr
   constructor(head: InvalidField) : this(nonEmptyListOf(head))
 }
 
+data class MissingParameter(val name: String) : ValidationError
+
 sealed interface UserError : DomainError
 
 data class UserNotFound(val property: String) : UserError

src/main/kotlin/io/github/nomisrev/env/Dependencies.kt

@@ -45,11 +45,12 @@ suspend fun ResourceScope.dependencies(env: Env): Dependencies {
     }
 
   return Dependencies(
-    userService,
-    jwtService,
-    articleService(slugGenerator, articleRepo, userRepo, tagPersistence, favouritePersistence),
-    checks,
-    tagPersistence,
-    userRepo
+    userService = userService,
+    jwtService = jwtService,
+    articleService =
+      articleService(slugGenerator, articleRepo, userRepo, tagPersistence, favouritePersistence),
+    healthCheck = checks,
+    tagPersistence = tagPersistence,
+    userPersistence = userRepo,
   )
 }

src/main/kotlin/io/github/nomisrev/repo/UserPersistence.kt

@@ -8,6 +8,7 @@ import io.github.nomisrev.DomainError
 import io.github.nomisrev.PasswordNotMatched
 import io.github.nomisrev.UserNotFound
 import io.github.nomisrev.UsernameAlreadyExists
+import io.github.nomisrev.routes.Profile
 import io.github.nomisrev.service.UserInfo
 import io.github.nomisrev.sqldelight.FollowingQueries
 import io.github.nomisrev.sqldelight.UsersQueries
@@ -35,6 +36,8 @@ interface UserPersistence {
   /** Select a User by its username */
   suspend fun select(username: String): Either<DomainError, UserInfo>
 
+  suspend fun selectProfile(username: String): Either<DomainError, Profile>
+
   @Suppress("LongParameterList")
   suspend fun update(
     userId: UserId,
@@ -104,6 +107,14 @@ fun userPersistence(
       ensureNotNull(userInfo) { UserNotFound("username=$username") }
     }
 
+    override suspend fun selectProfile(username: String): Either<DomainError, Profile> = either {
+      val profileInfo = usersQueries.selectProfile(username, ::toProfile).executeAsOneOrNull()
+      ensureNotNull(profileInfo) { UserNotFound("username=$username") }
+    }
+
+    fun toProfile(username: String, bio: String, image: String, following: Long): Profile =
+      Profile(username, bio, image, following > 0)
+
     override suspend fun update(
       userId: UserId,
       email: String?,

src/main/kotlin/io/github/nomisrev/routes/error.kt

@@ -10,6 +10,7 @@ import io.github.nomisrev.IncorrectInput
 import io.github.nomisrev.IncorrectJson
 import io.github.nomisrev.JwtGeneration
 import io.github.nomisrev.JwtInvalid
+import io.github.nomisrev.MissingParameter
 import io.github.nomisrev.PasswordNotMatched
 import io.github.nomisrev.UserNotFound
 import io.github.nomisrev.UsernameAlreadyExists
@@ -55,6 +56,7 @@ suspend fun PipelineContext<Unit, ApplicationCall>.respond(error: DomainError):
     is JwtInvalid -> unprocessable(error.description)
     is CannotGenerateSlug -> unprocessable(error.description)
     is ArticleBySlugNotFound -> unprocessable("Article by slug ${error.slug} not found")
+    is MissingParameter -> unprocessable("Missing ${error.name} parameter in request")
   }
 
 private suspend inline fun PipelineContext<Unit, ApplicationCall>.unprocessable(

src/main/kotlin/io/github/nomisrev/routes/profile.kt

@@ -1,12 +1,17 @@
+@file:Suppress("MatchingDeclarationName")
+
 package io.github.nomisrev.routes
 
 import arrow.core.raise.either
+import arrow.core.raise.ensure
+import io.github.nomisrev.MissingParameter
 import io.github.nomisrev.auth.jwtAuth
 import io.github.nomisrev.repo.UserPersistence
 import io.github.nomisrev.service.JwtService
 import io.ktor.http.HttpStatusCode
 import io.ktor.resources.Resource
 import io.ktor.server.resources.delete
+import io.ktor.server.resources.get
 import io.ktor.server.routing.Route
 import kotlinx.serialization.Serializable
 
@@ -22,11 +27,22 @@ data class Profile(
 
 @Resource("/profiles")
 data class ProfilesResource(val parent: RootResource = RootResource) {
+  @Resource("/{username?}")
+  data class Username(val parent: ProfilesResource = ProfilesResource(), val username: String?)
+
   @Resource("/{username}/follow")
   data class Follow(val parent: ProfilesResource = ProfilesResource(), val username: String)
 }
 
 fun Route.profileRoutes(userPersistence: UserPersistence, jwtService: JwtService) {
+  get<ProfilesResource.Username> { route ->
+    either {
+        ensure(!route.username.isNullOrBlank()) { MissingParameter("username") }
+        userPersistence.selectProfile(route.username).bind()
+      }
+      .respond(HttpStatusCode.OK)
+  }
+
   delete<ProfilesResource.Follow> { follow ->
     jwtAuth(jwtService) { (_, userId) ->
       either {

src/main/kotlin/io/github/nomisrev/routes/root.kt

@@ -9,7 +9,6 @@ fun Application.routes(deps: Dependencies) = routing {
   userRoutes(deps.userService, deps.jwtService)
   tagRoutes(deps.tagPersistence)
   profileRoutes(deps.userPersistence, deps.jwtService)
-  articleRoutes(deps.articleService, deps.jwtService)
 }
 
 @Resource("/api") data object RootResource

src/main/sqldelight/io/github/nomisrev/sqldelight/Users.sq

@@ -20,6 +20,16 @@ SELECT email, username, bio, image
 FROM users
 WHERE username = :username;
 
+selectProfile:
+SELECT users.username, users.bio, users.image,
+CASE
+    WHEN following.follower_id IS NULL THEN 0
+    ELSE 1
+END AS following
+FROM users
+LEFT JOIN following ON CAST(users.id AS BIGINT) = following.followed_id
+WHERE users.username = :username;
+
 selectSecurityByEmail:
 SELECT id, username, salt, hashed_password, bio, image
 FROM users

src/test/kotlin/io/github/nomisrev/routes/ProfileRouteSpec.kt

@@ -1,14 +1,18 @@
 package io.github.nomisrev.routes
 
+import io.github.nomisrev.env.Dependencies
 import io.github.nomisrev.service.RegisterUser
 import io.github.nomisrev.withServer
 import io.kotest.assertions.arrow.core.shouldBeRight
 import io.kotest.core.spec.style.StringSpec
 import io.kotest.matchers.shouldBe
 import io.ktor.client.call.body
 import io.ktor.client.plugins.resources.delete
+import io.ktor.client.plugins.resources.get
 import io.ktor.client.request.bearerAuth
+import io.ktor.http.ContentType
 import io.ktor.http.HttpStatusCode
+import io.ktor.http.contentType
 
 class ProfileRouteSpec :
   StringSpec({
@@ -66,4 +70,50 @@ class ProfileRouteSpec :
         response.status shouldBe HttpStatusCode.UnprocessableEntity
       }
     }
+
+    "Get profile with no following" {
+      withServer { dependencies: Dependencies ->
+        dependencies.userService
+          .register(RegisterUser(validUsername, validEmail, validPw))
+          .shouldBeRight()
+        val response =
+          get(ProfilesResource.Username(username = validUsername)) {
+            contentType(ContentType.Application.Json)
+          }
+
+        response.status shouldBe HttpStatusCode.OK
+        with(response.body<Profile>()) {
+          username shouldBe validUsername
+          bio shouldBe ""
+          image shouldBe ""
+          following shouldBe false
+        }
+      }
+    }
+
+    "Get profile invalid username" {
+      withServer {
+        val response =
+          get(ProfilesResource.Username(username = validUsername)) {
+            contentType(ContentType.Application.Json)
+          }
+
+        response.status shouldBe HttpStatusCode.UnprocessableEntity
+        response.body<GenericErrorModel>().errors.body shouldBe
+          listOf("User with username=$validUsername not found")
+      }
+    }
+
+    "Get profile by username missing username" {
+      withServer {
+        val response =
+          get(ProfilesResource.Username(username = "")) {
+            contentType(ContentType.Application.Json)
+          }
+
+        response.status shouldBe HttpStatusCode.UnprocessableEntity
+        response.body<GenericErrorModel>().errors.body shouldBe
+          listOf("Missing username parameter in request")
+      }
+    }
   })