Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap.type: 'boundary' not working after changing unit cell parameters and refreshing page #3

Open
peterschindler opened this issue Sep 10, 2023 · 0 comments

Comments

@peterschindler
Copy link
Contributor

Hi @lauri-codes ,
I recently played around with materia again and noticed that wrap.type: 'boundary' does not seem to work as intended when changing the unit cell dimensions and then refreshing the page (also closing and opening the page doesn't seem to fix it - making me think that my browser is caching the old unit cell values).

This can be reproduced by adding wrap: {type: 'boundary'} to the structure in examples/structure-periodic/structure.js - this works as intended. Now change the unit cell parameters in the js file and refresh the html page. Now the wrapped atoms are no longer showing up. This seems to be the case for both increasing and decreasing the cell parameters. Changing it back to the original lattice values and refreshing the page fixes the issue. Btw, I have been using the most recent version of Firefox.

I'm not sure what is causing this because the code that generates the wrapped atoms looks correct to me. Maybe it's caching the old unit cell parameters somehow causing the tolerance checking to be off?
Thanks for having a look!

-Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant