Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable importing .ksp files from folders (#400) broke some imports here (possible old math library related) #447

Open
dxmachina opened this issue Mar 1, 2024 · 4 comments

Comments

@dxmachina
Copy link

This commit specifically broke code that I'm maintaining here, possibly only related to the import of the old Big Bob math library. 63a497f

The line is simply: import "KSPMathV702.ksp"

Yields: Syntax error! (line 2279)
../common/external/KSPMathV702.ksp:4625

Release 1.17.0 is fine

@mkruselj
Copy link
Collaborator

mkruselj commented Apr 1, 2024

Hmmm, I have some code that imports that same file in exactly the same way and it all works fine still... Weird!

@dxmachina
Copy link
Author

Wow, really? Hmm.

It's obviously easy enough just to use the right commit when I need to get back to that code, but I figured a lot of people are maintaining code with the same library.

I did try a bunch of path simplifying to make sure it wasn't that. This was all on macOS.

Will take another look when I have some time.

@mkruselj
Copy link
Collaborator

Can you try with the very latest commit, please? Unsure if it'd fix but worth a shot I guess...

@dxmachina
Copy link
Author

Unfortunately, still an issue with the latest commit here. When I find some time I will see about debugging it here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants