From 8454b4d6ee0c762a53b101390afc9b07080a620d Mon Sep 17 00:00:00 2001
From: Maxim Vezenov <mvezenov@gmail.com>
Date: Wed, 8 Jan 2025 22:32:59 +0000
Subject: [PATCH 1/2] do not ower a Value::FormatString to a HirLiteral::Str

---
 .../noirc_frontend/src/hir/comptime/value.rs  | 33 +++++++++++++++++--
 .../execution_success/debug_logs/src/main.nr  | 11 +++++++
 2 files changed, 41 insertions(+), 3 deletions(-)

diff --git a/compiler/noirc_frontend/src/hir/comptime/value.rs b/compiler/noirc_frontend/src/hir/comptime/value.rs
index b5496507e80..0fd27d430be 100644
--- a/compiler/noirc_frontend/src/hir/comptime/value.rs
+++ b/compiler/noirc_frontend/src/hir/comptime/value.rs
@@ -20,7 +20,7 @@ use crate::{
     },
     node_interner::{ExprId, FuncId, NodeInterner, StmtId, StructId, TraitId, TraitImplId},
     parser::{Item, Parser},
-    token::{SpannedToken, Token, Tokens},
+    token::{FmtStrFragment, SpannedToken, Token, Tokens},
     Kind, QuotedType, Shared, Type, TypeBindings,
 };
 use rustc_hash::FxHashMap as HashMap;
@@ -363,8 +363,35 @@ impl Value {
                 HirExpression::Literal(HirLiteral::Str(unwrap_rc(value)))
             }
             // Format strings are lowered as normal strings since they are already interpolated.
-            Value::FormatString(value, _) => {
-                HirExpression::Literal(HirLiteral::Str(unwrap_rc(value)))
+            // We need to mock a FmtStr literal that matches the type expected elsewhere in the program.
+            // If we do not do this, we may end up with mismatched types
+            Value::FormatString(value, fmt_str_type) => {
+                // We include a space here as otherwise the ABI decoder will expect a value that does not exist.
+                let placeholder =
+                    interner.push_expr(HirExpression::Literal(HirLiteral::Str(" ".to_owned())));
+                interner.push_expr_location(placeholder, location.span, location.file);
+
+                let dummy_captures = match fmt_str_type {
+                    Type::FmtString(_, item_types) => {
+                        dbg!(item_types.clone());
+                        let Type::Tuple(fields) = *item_types else {
+                            return Err(InterpreterError::Unimplemented {
+                                item: "Only Type::Tuple is supported for format strings".to_owned(),
+                                location,
+                            });
+                        };
+                        std::iter::repeat(placeholder).take(fields.len()).collect()
+                    }
+                    _ => unreachable!("Expected a Type::FmtString"),
+                };
+
+                let raw_str = unwrap_rc(value);
+                let str_len = raw_str.len();
+                HirExpression::Literal(HirLiteral::FmtStr(
+                    vec![FmtStrFragment::String(raw_str)],
+                    dummy_captures,
+                    str_len as u32,
+                ))
             }
             Value::Function(id, typ, bindings) => {
                 let id = interner.function_definition_id(id);
diff --git a/test_programs/execution_success/debug_logs/src/main.nr b/test_programs/execution_success/debug_logs/src/main.nr
index 14344b1700b..39280d62ef8 100644
--- a/test_programs/execution_success/debug_logs/src/main.nr
+++ b/test_programs/execution_success/debug_logs/src/main.nr
@@ -1,7 +1,18 @@
+global A: Field = 50;
+global B: Field = 100;
+global GLOBAL_FMT_STR: fmtstr<14, (Field, Field)> = f"i: {A}, j: {B}";
+global GLOBAL_FMT_STR_BIG: fmtstr<22, (Field, Field, Field)> = f"i: {A}, j: {B}, k: {A}";
+
 fn main(x: Field, y: pub Field) {
     let string = "i: {i}, j: {j}";
     println(string);
 
+    println(GLOBAL_FMT_STR);
+    println(GLOBAL_FMT_STR_BIG);
+
+    let LOCAL_FMT_STR: fmtstr<14, (Field, Field)> = f"i: {A}, j: {B}";
+    println(LOCAL_FMT_STR);
+
     // TODO: fmtstr cannot be printed
     // let fmt_str: fmtstr<14, (Field, Field)> = f"i: {x}, j: {y}";
     // let fmt_fmt_str = f"fmtstr: {fmt_str}, i: {x}";

From 437a967404793132d2d30d2e7f118065fe236b32 Mon Sep 17 00:00:00 2001
From: Maxim Vezenov <mvezenov@gmail.com>
Date: Thu, 9 Jan 2025 03:26:55 +0000
Subject: [PATCH 2/2] update comment to be more specific

---
 test_programs/execution_success/debug_logs/src/main.nr | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test_programs/execution_success/debug_logs/src/main.nr b/test_programs/execution_success/debug_logs/src/main.nr
index 39280d62ef8..457a62ead15 100644
--- a/test_programs/execution_success/debug_logs/src/main.nr
+++ b/test_programs/execution_success/debug_logs/src/main.nr
@@ -13,7 +13,7 @@ fn main(x: Field, y: pub Field) {
     let LOCAL_FMT_STR: fmtstr<14, (Field, Field)> = f"i: {A}, j: {B}";
     println(LOCAL_FMT_STR);
 
-    // TODO: fmtstr cannot be printed
+    // TODO: fmtstr cannot be printed inside another fmtstr 
     // let fmt_str: fmtstr<14, (Field, Field)> = f"i: {x}, j: {y}";
     // let fmt_fmt_str = f"fmtstr: {fmt_str}, i: {x}";
     // println(fmt_fmt_str);