Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate ACIR generation for nested_array_dynamic #7000

Open
aakoshh opened this issue Jan 9, 2025 · 2 comments
Open

Investigate ACIR generation for nested_array_dynamic #7000

aakoshh opened this issue Jan 9, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@aakoshh
Copy link
Contributor

aakoshh commented Jan 9, 2025

Aim

A followup for #6972, see:

Expected Behavior

#6972 (comment)

Bug

The nested_array_dynamic example sees some bytecode increase after #6972
Upon closer inspection (see the linked comments above), the ACIR generated is suboptimal.

To Reproduce

cd test_programs/execution_success/nested_array_dynamic
argo run -p nargo_cli -- --program-dir . info --skip-underconstrained-check --skip-brillig-constraints-check --force --show-ssa --print-acir

#6972 (comment) contains a minimized verision of the test code.

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

nargo version = 1.0.0-beta.1 noirc version = 1.0.0-beta.1+bb8dd5ce43f0d89e393bd49f8415008826903652 (git version hash: 13b5871, is dirty: false)

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@aakoshh aakoshh added the bug Something isn't working label Jan 9, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 9, 2025
@vezenovm
Copy link
Contributor

vezenovm commented Jan 9, 2025

This is the proposal that @TomAFrench was referring to in the linked comments #6231. I am linking it here for visibility. I have some initial code that does this switch but was also reliant on separate runtimes before SSA #6841. I can clean it up and push the initial draft.

@aakoshh
Copy link
Contributor Author

aakoshh commented Jan 9, 2025

Awesome, thanks @vezenovm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants