Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACVM crate publishing is broken due to crates.io not taking Cargo.lock into account #4384

Closed
TomAFrench opened this issue Feb 15, 2024 · 0 comments · Fixed by #4385
Closed

Comments

@TomAFrench
Copy link
Member

TomAFrench commented Feb 15, 2024

The most recent publish to crates.io failed: https://github.com/noir-lang/noir/actions/runs/7876962954/job/21492099000

The reasoning behind this is that people who install our crates don't use our lockfile but bring their own so Cargo ignores ours and attempts to build with the most recent versions of our dependencies as part of the publishing process. This then fails due to some of our dependencies bumping their MSRVs above ours which borks the publish.

Cargo also doesn't check just the dependencies which are relevant for the crate being published for but all dependencies in the entire workspace. The ahash dependency in the failing publish is only used in nargo_cli for benchmarking but it blows up publishing anything from the workspace. This paragraph seems to be incorrect.

See rust-lang/cargo#8728

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 15, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 15, 2024
…d using updated lockfile (#4385)

# Description

## Problem\*

Resolves #4384 

## Summary\*

This PR resolves #4384 by updating the lockfile so that it's using the
latest versions of the dependencies used by all of the ACVM packages and
then runs the test suite against it to ensure that we still work
correctly.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: kevaundray <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
1 participant