Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipkin Example #61

Open
sberryman opened this issue Feb 25, 2017 · 1 comment
Open

Zipkin Example #61

sberryman opened this issue Feb 25, 2017 · 1 comment

Comments

@sberryman
Copy link

I see @paolochiodi (and @rjrodger) implemented zipkin support and have since updated the ramanujan project.

My question is how would you implement this as part of nodezoo? I'm assuming you add zipkin tracing to each individual micro-service?

Github as an example:

Would this be as simple as including seneca-zipkin-tracer and then adding this around line 46?

Service.use('zipkin-tracer', { sampling: 1 });

Obviously this is a change from your Iteration 3: Measurement where you use influxdb, grafana, etc.

@paolochiodi
Copy link

Hi Shaun.
I didn't touch nodezoo in a long time and I'm not entirely familiar with it but from what I see those steps unfortunately aren't enough.

seneca-zipkin-tracer require a recent seneca version, but from what I see nodezoo services are stuck with seneca 2.0.0.

Once they are up to date then yes, the steps you described should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants