Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server should include the Last-Modified header #1793

Open
csarven opened this issue Sep 10, 2024 · 3 comments
Open

Server should include the Last-Modified header #1793

csarven opened this issue Sep 10, 2024 · 3 comments
Assignees
Labels
feature good first issue An issue that should be quite easy for newcomers to fix

Comments

@csarven
Copy link
Member

csarven commented Sep 10, 2024

Server MUST generate a Last-Modified header field in response to GET and HEAD requests.

https://solidproject.org/ED/protocol#server-last-modified-includes

Servers are strongly discouraged from exposing information beyond the minimum amount necessary to enable a feature.

https://solidproject.org/ED/protocol#exposing-information

So, the implementation should only expose the Last-Modified header when access is granted to the request target, i.e., when user or public has Read access to the resource. This is typically aligned with the 200 response.

@csarven csarven added feature good first issue An issue that should be quite easy for newcomers to fix labels Sep 10, 2024
@csarven
Copy link
Member Author

csarven commented Sep 10, 2024

The modified timestamp can be easily retrieved using fs.stat and mtime.


Here is a screencast showing an application making use of the header field in one particular way:

https://dokie.li/media/video/dokieli-last-modified.webm

dokieli-last-modified.webm

See also solid/specification#678 (comment)

@knishkagithub
Copy link

i would like to work in this issue,could you please assign it to me

@csarven
Copy link
Member Author

csarven commented Oct 12, 2024

@knishkagithub , not sure if you got a notification about @bourgeoa assigning this issue to you but all yours now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue An issue that should be quite easy for newcomers to fix
Projects
None yet
Development

No branches or pull requests

2 participants