Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSS try to create path, filename containing invalid windows characters like colon #1536

Open
bourgeoa opened this issue Dec 6, 2020 · 4 comments

Comments

@bourgeoa
Copy link
Member

bourgeoa commented Dec 6, 2020

@timbl @michielbdejong @RubenVerborgh @highlevellogic

Trying NSS on a windows pod https://bourgeoa.solid.hll.nu:7443 . Tested the chat with me from OS solid
The function returns a PUT error 500

FAILED to save new chat channel at: https://bourgeoa.solid.hll.nu:7443/IndividualChats/bourgeoa.solid.hll.nu:7443/index.ttl : Web error: 500 (Internal Server Error) on PUT of https://bourgeoa.solid.hll.nu:7443/IndividualChats/bourgeoa.solid.hll.nu:7443/index.ttl

This is due to the colon : in the folderPath

To ensure solid compatibility can we forbid the windows forbidden characters in pathName like \/:*%"<>| ?
This could be done in resource-mapper.js
Should it be OS dependent to allow any file OS file be URI capable.

index:name.ttl is valid POSIX file and URI, but invalid WINDOWS

@bourgeoa
Copy link
Member Author

bourgeoa commented Dec 6, 2020

@jeff-zucker this may have some impact on solid-rest

@jeff-zucker
Copy link
Member

Yes, solid-rest needs to be able to translate requests for valid URLs into valid file names on whatever the backend is.

@highlevellogic
Copy link
Contributor

Is it necessary for the port to be included in the directory name?
What problem would be caused by creating chat directories like account directories, without the port?

@bourgeoa
Copy link
Member Author

bourgeoa commented Dec 8, 2020

@highlevellogic see PR SolidOS/chat-pane#50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants