Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle embed and preview in markdown and HTML #45

Open
4 tasks
nobe4 opened this issue Jun 16, 2022 · 0 comments
Open
4 tasks

Handle embed and preview in markdown and HTML #45

nobe4 opened this issue Jun 16, 2022 · 0 comments
Assignees
@nobe4
Labels
enhancement New feature or request, alias: improvements.

Comments

@nobe4
Copy link
Owner

nobe4 commented Jun 16, 2022 •
edited
Loading

Tasks

  • Create base parser
  • Create youtube-specific embed
  • Create nitter-specific embed
  • ...

HTML

Use iframe when possible.
Dompurify removes iframes.

Markdown

Have iframe code and link

It's not possible to embed an iframe, but having the thumbnail + a link would be nice.

cc https://stackoverflow.com/a/29862696
cc https://stackoverflow.com/a/14945782
cc https://gist.github.com/bitsurgeon/acd769ae3236c48a433e0acb11784c2e
@nobe4 nobe4 added the enhancement New feature or request, alias: improvements. label Jun 16, 2022
@nobe4 nobe4 changed the title Add youtube preview Handle embed in markdown and HTML Jul 14, 2022
@nobe4 nobe4 changed the title Handle embed in markdown and HTML Handle embed and preview in markdown and HTML Jul 14, 2022
@nobe4 nobe4 mentioned this issue Sep 10, 2022
Merged
@nobe4 nobe4 self-assigned this Sep 10, 2022
@nobe4 nobe4 mentioned this issue Sep 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nobe4 nobe4

Labels
enhancement New feature or request, alias: improvements.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nobe4