Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: How does the "collect-first" on enchantment's work exactly? #79

Open
Gabo6480 opened this issue Jul 27, 2022 · 6 comments
Open

Comments

@Gabo6480
Copy link

I have received reports by my players that they are not able to buy enchantments they expect to be able to buy already.
I want to know which method of obtaining an enchantment is the one expected by the plugin. Since players might consider as obtaining an enchantment as any of the following:

  • Finding an item with the enchantment already in it trough any means.
  • Getting an enchanted book with the enchantment trough any means.
  • Getting the enchantment trough the enchantment table.
@noahbclarkson
Copy link
Owner

An enchantment is unlocked when a player holds an item, including an enchanted book, that holds that enchantment. Another thing to note is that by default the collect-first-setting for enchantments is set to "player".

@Gabo6480
Copy link
Author

Gabo6480 commented Jul 27, 2022 via email

@noahbclarkson
Copy link
Owner

In their inventory

@Gabo6480
Copy link
Author

Then there might be some sort of bug, since some of my players have reported acquiring the an enchantment and still being unable to buy it on the shop. I even tried dropping myself a Looting 3 book from creative and was still unable to buy the enchantment.

@noahbclarkson
Copy link
Owner

Okay I will look into it today

noahbclarkson added a commit that referenced this issue Jul 28, 2022
Refactor AutoTuneInventoryCheckEvent to be more stable (hopefully). Reset buy/sell limits on each time period regardless of player count.
@muazhari
Copy link

muazhari commented Oct 30, 2022

Then there might be some sort of bug, since some of my players have reported acquiring the an enchantment and still being unable to buy it on the shop. I even tried dropping myself a Looting 3 book from creative and was still unable to buy the enchantment.

Same here. I have this bug too in my server. Even when I edit collect-first to none, in the plugin in-game shop didn't change too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants