Replies: 15 comments 24 replies
-
Sorry I missed that message somehow!
|
Beta Was this translation helpful? Give feedback.
-
@no-chris Any decisions about the sub-beat chord format? |
Beta Was this translation helpful? Give feedback.
-
This has been implemented in #587 It is part of ChordMark 0.13.0 beta version: https://github.com/no-chris/chord-mark/releases/tag/v0.13.0-beta.0 |
Beta Was this translation helpful? Give feedback.
-
Hi Chris.
I am super excited to see this in action, but when I try the sub-beat chords the rendering is not working. Maybe the code did not deploy?
|
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Thanks for the feedback!
Duh, I was afraid someone would ask for that 😱 I guess we could yes, I did it for the the bar separator, it was painful enough, but I guess replicating it for sub-beats should be easier now that the hard work is done.
That's easy enough to experiment, we can just disable the rendering of the braces with
Nice! I'll keep this idea as a nice to have feature, as it would require rewriting the parsing algorithm, and since sub-beat duration chords are not that common in the end, I think the extra work of writing the braces is acceptable for now. |
Beta Was this translation helpful? Give feedback.
-
Ah, a preference is a perfect solution. I like the way it looks with no braces. I believe the reason I don't like the rendered braces is that they are very "busy" compared with the minimalist vibe of the rendered content. Perhaps a different delimiter would be cleaner? It seems that only "paired" (i.e. different start and end characters) delimiters are clear enough to avoid ambiguity in an environment with flexible spacing. Some ideas for rendering: ⟨ Am Am/G ⟩ |
Beta Was this translation helpful? Give feedback.
-
I agree with the "minimalist vibe". I like plain square brackets actually, I feel they are more in line with the rest of the rendering (Note that I've managed to fix the delimiter position 😅 #597 |
Beta Was this translation helpful? Give feedback.
-
With the delimiter position correct and brackets it looks much nicer. However, I thought we decided not to use brackets as input since they are sometimes used in chord symbols; am I wrong? In any case I agree that brackets probably do look too much like bars. |
Beta Was this translation helpful? Give feedback.
-
Parenthesis are used in chord symbols, not square brackets |
Beta Was this translation helpful? Give feedback.
-
Ok, so square brackets As for what we render, I still agree with you that square brackets look too much like bars. But the input character can be different than output character. |
Beta Was this translation helpful? Give feedback.
-
I've updated the deploy preview with square brackets both for parsing & rendering and adapted the styling so they would stand out more from bar separators. Let me know what you think
|
Beta Was this translation helpful? Give feedback.
-
You made the brackets stand out from the bars, so that is good. But it is becoming clear to me that using delimiters for sub-beats and then postfix punctuation for beats is too dissonant. I like the idea of delimited groups in principal, but in practice it is messing up your minimalist ethos. So, let's go back to one of our original ideas: the comma. Am. Am, Am/G, FM7. F6. The parser sees two chords in a row with commas, so it knows they are eighth notes. This renders as:
That is clean and simple, for input and output. For the pathological case of an eighth note pair next to a triplet, we could still allow optional grouping via tick marks. A. Am, Am/G, G. `C, F, C,`
My original issue with the comma is that it is hard to distinguish from a period when rendered. However, as an input character it seems perfect, with the proper tail of an eighth note! |
Beta Was this translation helpful? Give feedback.
-
Thanks for all your feedback! You never seem to run out of ideas 😄 I think I like the delimiter option better, for the following reasons:
|
Beta Was this translation helpful? Give feedback.
-
Many songs have passing chords that have a duration of an eighth-note. For example, Elton John's "Don't Let the Sun Go Down On Me". For ChordMark to support that, we would need a way to notate smaller units than a beat in the lyrics and the chords. Has this been considered?
Beta Was this translation helpful? Give feedback.
All reactions