Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate() should mark NNNN alleles for DRB3/4/5 #338

Open
pbashyal-nmdp opened this issue Nov 21, 2024 · 2 comments
Open

validate() should mark NNNN alleles for DRB3/4/5 #338

pbashyal-nmdp opened this issue Nov 21, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@pbashyal-nmdp
Copy link
Contributor

Typings for DRB3/4/5 can be marked as +ve/-ve with:

Positive: XXXX
Negative: NNNN

eg. DRB3*NNNN.

py-ard currently says they are invalid.

>>> import pyard
>>> ard = pyard.init()
>>> ard.validate('DRB3*NNNN')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
....
pyard.exceptions.InvalidAlleleError: Invalid Allele: DRB3*NNNN is not a valid Allele
>>>

py-ard should treat them as valid alleles.

@pbashyal-nmdp pbashyal-nmdp added the enhancement New feature or request label Nov 21, 2024
@pbashyal-nmdp pbashyal-nmdp self-assigned this Nov 21, 2024
@mmaiers-nmdp
Copy link
Contributor

That depends. If py-ard is used in a context (WMDA business rules) where they are valid then yes but not if they are not. Similar to tolerating the movement of the expression characters to shortened versions of the alleles, these are WMDA-isms so maybe (like reduce_shortnull) this could be a configurable parameter like allow_wmda_presence_absence

@pbashyal-nmdp
Copy link
Contributor Author

Thanks for the explanation. Makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants