Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dupes now appearing in "G" mode #337

Open
mmaiers-nmdp opened this issue Nov 20, 2024 · 3 comments
Open

dupes now appearing in "G" mode #337

mmaiers-nmdp opened this issue Nov 20, 2024 · 3 comments
Assignees

Comments

@mmaiers-nmdp
Copy link
Contributor

image
This is a Google Colab session with these three commands

pip install py-ard

installs version 1.5.3

import pyard

ard = pyard.init()

and

ard.redux("HLA-A*02:GNF", "G")

which returns

HLA-A*02:01:01G/HLA-A*02:01:02G

We need this to be dupe squashed. Isn't this the default?

@mmaiers-nmdp
Copy link
Contributor Author

same problem for redux mode "P" but not "lg", "lgx"
image

@pbashyal-nmdp
Copy link
Contributor

pbashyal-nmdp commented Nov 20, 2024

The dupes are only "squashed" for ARD level. #333

@mmaiers-nmdp
Copy link
Contributor Author

Let’s extend that to all resolutions. Arguably a glstring with X/X is semantically correct. I can’t think of any reason why there shouldn’t be a general dupe squashing (within allele ambiguities) within all glstring every time everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants