Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syllables not coming out correctly on the website #16

Open
factormystic opened this issue Jul 2, 2016 · 3 comments
Open

syllables not coming out correctly on the website #16

factormystic opened this issue Jul 2, 2016 · 3 comments

Comments

@factormystic
Copy link

right now, houston texas is

  • houston
  • texas

which is wrong. but houstontexas is

  • hous
  • ton
  • te
  • xas

and houston and texas separately are also correct. pretty sure this is a website thing, because:

let s = nlp.text("houston texas").syllables();
> [ [ [ 'hous', 'ton' ], [ 'te', 'xas' ] ] ]
@spencermountain
Copy link
Contributor

spencermountain commented Jul 2, 2016

yeah, thanks. this nested response format is pretty nutty. Term.syllables() should definitely always return an array of strings, no matter how many words are in the term. I don't know why it's doing that.

@nloveladyallen
Copy link
Contributor

Huh. I'm seeing it one level deeper than @factormystic.

> nlp.text('houston texas').syllables()
[ [ [ [Object], [Object] ] ] ]
> nlp.text('houston texas').syllables()[0]
[ [ [ 'hous', 'ton' ], [ 'te', 'xas' ] ] ]

@spencermountain
Copy link
Contributor

yeah. I also had the thought that maybe it should return this, just like all the other text/sentence methods do - that way you can be smart about whitespace and all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants