-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid orphaned headlines (headline at the end of a volume) #88
Comments
See pending test here: pipeline/modules/nlb/book-to-pef/src/test/xprocspec/test_dtbook-to-pef_volume-breaking.xprocspec Line 758 in 5011f45
|
Related: #91 |
We ended up not using (EDIT: The reasoning here is that the closer you get to a preferred break point, the bigger the chance is that you "snap" to that break point. Or in other words, it is more likely that an actual break point lies further away from a preferred one than close but not on it.) |
@KariRudjord and I discussed this today. We agreed that it should be as described by @bertfrees in the previous comment (#88 (comment)). In addition, we want to try having a |
@josteinaj What is the current status? I'm still assigned, but I see you updated and simplified the volume breaking CSS last week. The test ("Content at start of part should be in same volume as first descendant chapter") still passes. You didn't add the |
@bertfrees I'll unassign you. I think I originally assigned this to you in a bulk of other volume breaking issues. Adding |
As mentioned in #88 (comment), we want to try avoiding orphaned headlines by using I've pushed a test for orphaned headlines. |
I've added the following CSS: pipeline/modules/nlb/book-to-pef/src/main/resources/css/nlb-default.scss Lines 167 to 174 in 630bc43
Note that for very small sections (smaller than one sheet) this might have an undesired effect, but I suggest you try it first. A solution could be to set Also note that |
So for this to be a problem, I suppose there would for instance have to be a series of very short level2s containing very short level3s. And there would have to be enough of them so that they fill an entire volume... Right? Would there potentially be some volume breaking exception, or would it just result in bad volume breaking? |
Right, I think that's what I mean. But even if there are not enough to fill an entire volume, it may result in sheets being kept together when not desired. I don't think it would cause exceptions. Just non-optimal volume breaking. |
Ok. I'll move this to "Ready for test", and we'll see what @KariRudjord has to say. |
...or "Ready for deployment" for now. I suppose this should wait until the system is fully updated to the latest DP2 release. |
In DTBook 561894 first volume ends with the page Part 1. It should be the first page in vol. 2. (much text in preface in this partiuclar book) @josteinaj will add some rule saying keep with next page to avoid this. |
We agreed some weeks ago that instead of moving content from the start of a part or chapter into the same volume as first descendant chapter or subchapter, we want to maximize the number of pages used in each volume. However, if the content is very short (for instance just a headline), then we still want to make sure that it is in the same volume as the first following content section, so that we avoid orphaned headlines. I'm trying to get this working using the |
Example:
Here, the h1 and p has a tendency to end up in the volume before level2.
The text was updated successfully, but these errors were encountered: