Add From<libc::sockaddr_ll> for LinkAddr
#2396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you consider the |
|
My current concert of this kind of conversion is that it can be unsafe since we have no guarantee from the values set in those raw libc types, see #2327 (comment)
No since they are newly-added things |
2 tasks
|
I filed an alternative PR (#2397) to address the concern of invalid data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This PR adds a
impl From<libc::sockaddr_ll> for LinkAddrto help users of nix avoidunsafecode. See #2059 (comment) for reference.Checklist:
CONTRIBUTING.md[ ] I have written necessary tests and rustdoc comments[ ] A change log has been added if this PR modifies nix's API